Add support for backend compatibility (#483)#611
Merged
austindrenski merged 1 commit intonpgsql:hotfix/2.1.2from Aug 19, 2018
Merged
Add support for backend compatibility (#483)#611austindrenski merged 1 commit intonpgsql:hotfix/2.1.2from
austindrenski merged 1 commit intonpgsql:hotfix/2.1.2from
Conversation
Member
|
Hmm, this definitely contains more than just the pure backwards compat feature - this is good example why it's important to separate refactoring and other changes into different commits. We ideally want to take only what is absolutely needed when backporting to a hotfix release. But this looks safe enough I guess. OK for me. |
roji
approved these changes
Aug 19, 2018
Contributor
Author
|
I considered only bringing forward the compatibility portion of this, but then thought it was worth bringing the fix forward too since this was introduced to address the translation breaking behavior for 9.x. But noted on keeping these commits more limited in scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting per #607.