Skip to content

Bug fix for UTC offset formatting #322

Closed
austindrenski wants to merge 8 commits intonpgsql:devfrom
austindrenski:timezone-fix
Closed

Bug fix for UTC offset formatting #322
austindrenski wants to merge 8 commits intonpgsql:devfrom
austindrenski:timezone-fix

Conversation

@austindrenski
Copy link
Contributor

Fixes a failing test when building the test suite in a timezone with a negative UTC offset.

#321

@austindrenski austindrenski deleted the timezone-fix branch May 27, 2018 04:48
@roji
Copy link
Member

roji commented May 27, 2018

@austindrenski, your actual commit (82af24f) looks good, even if needs to be properly rebased. Do you intend to resubmit a cleaner version of this PR? Or does your change not work as intended?

@austindrenski austindrenski restored the timezone-fix branch May 27, 2018 18:11
@austindrenski austindrenski deleted the timezone-fix branch May 27, 2018 18:24
@austindrenski austindrenski restored the timezone-fix branch May 27, 2018 18:28
@austindrenski
Copy link
Contributor Author

Actually, I think the root of the issue was fixed in 98970aa. To double check, I rebased and pushed 1b1001a.

At this point, I think it's just a style difference, so feel free to re-close if you want.

@roji
Copy link
Member

roji commented May 27, 2018

As it's just a test, I don't think it really matters... We can leave it the way it is.

@austindrenski austindrenski self-assigned this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants