Fix: text area had a border when "Border Width" option was set to 0#707
Fix: text area had a border when "Border Width" option was set to 0#707Rikk wants to merge 1 commit intonotepad-plus-plus:masterfrom
Conversation
9400a88 to
69159e9
Compare
|
This PR is much better than the previous one - no more regression. |
|
Why not enhancement? It is a great thing for the user to be able to use leftmost/rightmost pixels. |
|
Imo, enhancements, as well new features, may or may not change behaviors. |
|
👍 |
69159e9 to
f290807
Compare
|
I can kind of see what @donho means. With the white theme and a 0 border, the top of the text area has nothing to delineate it from the tab area any more. |
|
Yes, that's a very minor drawback, if there's a way to draw a solid line there, it would fix that. (Maybe a fake window with 0 height and WS_BORDER style? Dunno if it is possible in C++ and how to place in correct position) Btw, the reason for keeping old behavior (ie. keep WS_EX_CLIENTEDGE) when border is more than 0, is because the scrollbar of Windows 8/8.1/10 theme has almost the same color of window/menu background (that kind of gray). Otherwise, I would just simply remove that style. |
|
Compared to alot of people here my Win32 API knowledge is limited, so I can't really offer any suggestions. I'm just speaking from the pure "user" aspect of the changes. :) |
f290807 to
975bf03
Compare
|
For me, it is quite better with this update. It is the tab that should be updated, not an additional line to draw a border :) |
|
👍 |
|
Exactly. Firefox is a great example! |
|
I think this is a good PR. In cases where the user has a white theme and would like a small border, they can always leave the border value set to at least 1. |
Then that defeats the whole purpose. |
|
Imo the lack of a top/bottom line (not border) is insignificant. |
|
What's the purpose of adjustable border anyway (or any kind of border for that matter)? |
👆 |
|
I think this would greatly improve usability, as I've made a similar request! |
|
I've checked preferences dialogue in NPP 6.8.8 and did not found the setting - do I have to wait for a new update or is it in - if yes: where? |
|
Preferences → Editing → "Border Width" options at the bottom centre of the window → "No edge" checkbox |
|
Thank you, I've see it now. |
|
You need to set "Border Width" to 0, enable "No edge", and also maximize the window. Works for me. |

This is a possible fix for #619.
This makes possible:
It keeps old behavior when border is more than 0.
Sample:
