Skip to content

Fix: text area had a border when "Border Width" option was set to 0#707

Closed
Rikk wants to merge 1 commit intonotepad-plus-plus:masterfrom
Rikk:fix-border-width0
Closed

Fix: text area had a border when "Border Width" option was set to 0#707
Rikk wants to merge 1 commit intonotepad-plus-plus:masterfrom
Rikk:fix-border-width0

Conversation

@Rikk
Copy link
Copy Markdown
Contributor

@Rikk Rikk commented Aug 12, 2015

This is a possible fix for #619.

This makes possible:

  • Direct selection of entire line when mouse is at leftmost pixel of the window.
  • Using scrollbar when mouse is at rightmost pixel of the window.

It keeps old behavior when border is more than 0.

Sample:
fix-border=0

@Rikk Rikk force-pushed the fix-border-width0 branch from 9400a88 to 69159e9 Compare August 12, 2015 19:43
@donho
Copy link
Copy Markdown
Member

donho commented Aug 12, 2015

This PR is much better than the previous one - no more regression.
However, it's not pretty at all in my original (white) theme.
This PR is about change the default behaviour but not a bug-fix or an enhancement.
I'll think about it.

@Rikk
Copy link
Copy Markdown
Contributor Author

Rikk commented Aug 12, 2015

Why not enhancement? It is a great thing for the user to be able to use leftmost/rightmost pixels.

@Rikk
Copy link
Copy Markdown
Contributor Author

Rikk commented Aug 12, 2015

Imo, enhancements, as well new features, may or may not change behaviors.
Maybe you would like to keep this for a higher version? 6.9?

@Croydon
Copy link
Copy Markdown
Contributor

Croydon commented Aug 12, 2015

👍

@Rikk Rikk force-pushed the fix-border-width0 branch from 69159e9 to f290807 Compare August 13, 2015 01:45
@dail8859
Copy link
Copy Markdown
Contributor

I can kind of see what @donho means. With the white theme and a 0 border, the top of the text area has nothing to delineate it from the tab area any more.

@Rikk
Copy link
Copy Markdown
Contributor Author

Rikk commented Aug 14, 2015

Yes, that's a very minor drawback, if there's a way to draw a solid line there, it would fix that. (Maybe a fake window with 0 height and WS_BORDER style? Dunno if it is possible in C++ and how to place in correct position)

Btw, the reason for keeping old behavior (ie. keep WS_EX_CLIENTEDGE) when border is more than 0, is because the scrollbar of Windows 8/8.1/10 theme has almost the same color of window/menu background (that kind of gray). Otherwise, I would just simply remove that style.

@dail8859
Copy link
Copy Markdown
Contributor

Compared to alot of people here my Win32 API knowledge is limited, so I can't really offer any suggestions. I'm just speaking from the pure "user" aspect of the changes. :)

@Rikk Rikk force-pushed the fix-border-width0 branch from f290807 to 975bf03 Compare August 15, 2015 00:22
@milipili
Copy link
Copy Markdown
Contributor

For me, it is quite better with this update. It is the tab that should be updated, not an additional line to draw a border :)

@h-h-h-h
Copy link
Copy Markdown
Contributor

h-h-h-h commented Sep 2, 2015

👍
As in other software (Firefox) there should be a top border, but no side borders. A bottom border wouldn't be bad.

@dail8859
Copy link
Copy Markdown
Contributor

dail8859 commented Sep 2, 2015

Exactly. Firefox is a great example!

@Eldaw
Copy link
Copy Markdown

Eldaw commented Sep 3, 2015

I think this is a good PR. In cases where the user has a white theme and would like a small border, they can always leave the border value set to at least 1.

@dail8859
Copy link
Copy Markdown
Contributor

dail8859 commented Sep 3, 2015

I think this is a good PR. In cases where the user has a white theme and would like a small border, they can always leave the border value set to at least 1.

Then that defeats the whole purpose.

@Rikk
Copy link
Copy Markdown
Contributor Author

Rikk commented Sep 3, 2015

Imo the lack of a top/bottom line (not border) is insignificant.

@aaaxx
Copy link
Copy Markdown

aaaxx commented Sep 3, 2015

What's the purpose of adjustable border anyway (or any kind of border for that matter)?

@h-h-h-h
Copy link
Copy Markdown
Contributor

h-h-h-h commented Sep 4, 2015

@aaaxx:

What's the purpose of adjustable border anyway (or any kind of border for that matter)?

👆

@pkrabbit
Copy link
Copy Markdown

pkrabbit commented Nov 2, 2015

I think this would greatly improve usability, as I've made a similar request!
Maybe a solution would be hiding the side borders only when maximized.

@donho donho closed this in 6c7ca02 Dec 4, 2015
@GitMensch
Copy link
Copy Markdown
Contributor

I've checked preferences dialogue in NPP 6.8.8 and did not found the setting - do I have to wait for a new update or is it in - if yes: where?
As soon as it's in I think #1071 can be closed with a comment how to set this option.

@aaaxx
Copy link
Copy Markdown

aaaxx commented Feb 11, 2016

Preferences → Editing → "Border Width" options at the bottom centre of the window → "No edge" checkbox

@yne
Copy link
Copy Markdown

yne commented Feb 11, 2016

It should be located in :
Preference > Editing > Border width > No edge
screencap

@GitMensch
Copy link
Copy Markdown
Contributor

Thank you, I've see it now.
Rechecked: This doesn't solve #1071.

@XP1
Copy link
Copy Markdown

XP1 commented Feb 12, 2016

@GitMensch

You need to set "Border Width" to 0, enable "No edge", and also maximize the window. Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.