Skip to content

Make the MinGW/GCC build work again#4776

Closed
marcows wants to merge 7 commits intonotepad-plus-plus:masterfrom
marcows:gcc-fixes
Closed

Make the MinGW/GCC build work again#4776
marcows wants to merge 7 commits intonotepad-plus-plus:masterfrom
marcows:gcc-fixes

Conversation

@marcows
Copy link
Copy Markdown
Contributor

@marcows marcows commented Aug 19, 2018

  • updated the MinGW specific build files
  • fixed build errors
  • created stubs or excluded code parts for non-supported functionality

NP++ can now be built without errors and executed again.
Tested under Windows 7 using GCC 8.1.0 with POSIX threads and dwarf.

This feature cannot be built because ATL is not supported.

Building and running successfully now without the file browser feature.
…W stubs

Necessary since addition of "Log Monitoring (tail -f)" feature.
…ation

Fixes a runtime error with the MinGW/GCC build on startup:

Exception On WM_CREATE
locale::facet::_S_create_c_locale name not valid
@chcg
Copy link
Copy Markdown
Contributor

chcg commented Aug 28, 2018

@marcows See #4320 and #4145 for pending PRs containing pieces of your PR.

@marcows
Copy link
Copy Markdown
Contributor Author

marcows commented Aug 30, 2018

Yes, I had seen them. It was hard getting patches integrated upstream in the past and I just wanted to try one last time with my existing work. I don't plan continuing, the time is better spent elsewhere. As long as the GCC build is only second-class citizen, you will always be fixing after and need luck getting them applied.

@donho
Copy link
Copy Markdown
Member

donho commented Nov 7, 2019

Duplicated:
#4145

@donho donho closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants