Skip to content

Cleanup in context menu and Run entries#4513

Closed
vlakoff wants to merge 1 commit intonotepad-plus-plus:masterfrom
vlakoff:actions
Closed

Cleanup in context menu and Run entries#4513
vlakoff wants to merge 1 commit intonotepad-plus-plus:masterfrom
vlakoff:actions

Conversation

@vlakoff
Copy link
Copy Markdown
Contributor

@vlakoff vlakoff commented May 21, 2018

  • Context menu: remove entry "Google Search"

    • redundant with the "Search On Internet" entry
    • … and just noneffective as the corresponding Run entry has been removed
    • introduced in e451efb, see also my past comment on it: e451efb#r22615404
  • Run commands: remove entry "Launch in Safari"

    • Safari for Window is just discontinued
    • … and nobody was using it
  • Fix case: "Get php help" → "Get PHP help"

@vlakoff
Copy link
Copy Markdown
Contributor Author

vlakoff commented May 21, 2018

Another nitpick: fix case "Search On Internet" → "Search on Internet"

(no change in practice, because the corresponding menu item was already with lowercase "on")

@donho
Copy link
Copy Markdown
Member

donho commented May 21, 2018

@vlakoff
Even the dev of Safari under windows is discontinued, it's not the reason to remove this shortcut.

and nobody was using it

what's the tangible proof to make you say that?

@vlakoff
Copy link
Copy Markdown
Contributor Author

vlakoff commented May 21, 2018

I do maintain this menu entry is not worth it.
For me this is pretty clear, and I don't plan to argue about it.

"Less is more" principle, keeping such useless entry make the useful entries harder to spot.

But it's up to you :)

@donho
Copy link
Copy Markdown
Member

donho commented May 22, 2018

I do agree "Less is more" principle.
The thing is, it's not enough "For me this is pretty clear" argument, because our personal experience is limit.
If you have more solid arguments or proof, feel free to let me know and I'm ready to remove this entry.
Otherwise, please restore it, then I'll accept the PR.

@vlakoff
Copy link
Copy Markdown
Contributor Author

vlakoff commented May 22, 2018

If today, in a parallel universe, this entry was not present and there were a PR to add such an entry, would you accept it?

The Safari entry has been added along the Chrome one, in 2009 (at that time, Chrome was pretty new, far from the popularity it has now).

@chcg
Copy link
Copy Markdown
Contributor

chcg commented May 23, 2018

See https://en.wikipedia.org/wiki/Safari_version_history#Version_compatibility
and (also in german) http://www.chip.de/downloads/Safari_27264736.html.

Latest safari version for windows is 5.1.7 from 2012, also for Mac it is 11.1. So the advice is not to install it any more due to security risks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants