Update code in FileManager::reloadBuffer to correctly detect line endings and encoding#4077
Closed
CookiePLMonster wants to merge 1 commit intonotepad-plus-plus:masterfrom
CookiePLMonster:issues_3557
Closed
Update code in FileManager::reloadBuffer to correctly detect line endings and encoding#4077CookiePLMonster wants to merge 1 commit intonotepad-plus-plus:masterfrom CookiePLMonster:issues_3557
CookiePLMonster wants to merge 1 commit intonotepad-plus-plus:masterfrom
CookiePLMonster:issues_3557
Conversation
This was referenced Jan 12, 2018
Member
|
@CookiePLMonster The following PR will be chosen for the fix of #4034 due to its simplicity: Please redo another PR for the other issues. |
Contributor
Author
|
Sure! I'll wait until the other PR is merged and re-submit, so it'll be of narrower scope. |
Member
|
@CookiePLMonster Done: 46d0f12 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2637, #2843, #3557 and #4033 (maybe more?)
PR seems nearly identical to rejected #2633, however I have actually compiled and tested this and all test cases work fine.
This PR mirrors encoding/EOL detection present in
FileManager::loadFiletoFileManager::reloadBuffer. As a result, I observed following issues when reloading files modified outside of Notepad++ are fixed: