Fixed "HTML Enclose Tag" #868 #1192
Closed
Conversation
…through xml definition of system versus self testing character sequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code change is to add a check for a comment style inside xmlMatchedTagsHighlighter.cpp, and to ignore opening/closing tags inside a comment. Now HTML and XML tags are properly ignored in comments, and HTML/XML tags highlight the first matching closing tag after the end of the comment, as one would expect.
We tested on Windows 7 and Windows 8.1 with Notepad++ version 6.8.6.
No additional plugins were installed, we just ran as it was compiled, with boost enabled.
Here is a image of the working highlighter, a screenshot of the bug is available in bug report #868
