Skip to content

Character encodings are broken #3991

@dnakamura

Description

@dnakamura

Description of the Issue

The heart of the issue lies in the way the menu item IDS interact with the EncodingMapper. IE a constant is subtracted from the ID and used as an index into the encoding map

int index = id - IDM_FORMAT_ENCODE;
EncodingMapper *em = EncodingMapper::getInstance();
int encoding = em->getEncodingFromIndex(index);

However with the recent removal of a number of unused character encodings (60f1137), causes this to breakdown. the command IDs remain the same, however the indexes in the Encoding map have changed. This means that any encoding with a command id greater than the first deleted encoding, no longer behaves as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions