Skip to content

doc: update signature specification for v1 release #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yizha1 merged 21 commits into from
Aug 3, 2023
Merged

doc: update signature specification for v1 release #256

yizha1 merged 21 commits into from
Aug 3, 2023

Conversation

@yizha1
Copy link
Contributor

@yizha1 yizha1 commented May 6, 2023

Resolve #255

Signed-off-by: Yi Zha yizha1@microsoft.com

@yizha1
doc: update signature specification for v1 release
d9ee4ad 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
iamsamirzon
iamsamirzon reviewed May 8, 2023
View reviewed changes
Copy link

@iamsamirzon iamsamirzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yizha1 - For this set of changes, I believe changing "Notary v2" to "Notary" is not the right decision. I will suggest replacing "Notary v2" to "Notary Project" will be more appropriate. I am basing it on - "https://cloud-native.slack.com/archives/CQUH8U287/p1678224360929939?thread_ts=1678194257.621559&cid=CQUH8U287" discussion

toddysm
toddysm requested changes May 9, 2023
View reviewed changes
@yizha1
doc: update per comments
5300247 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested review from iamsamirzon and toddysm May 10, 2023 11:10
iamsamirzon
iamsamirzon reviewed May 10, 2023
View reviewed changes
iamsamirzon
iamsamirzon reviewed May 10, 2023
View reviewed changes
iamsamirzon
iamsamirzon previously approved these changes May 10, 2023
View reviewed changes
toddysm
toddysm requested changes May 10, 2023
View reviewed changes
@yizha1
doc: update per comments
a48eda2 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested review from iamsamirzon and toddysm May 11, 2023 05:12
shizhMSFT
shizhMSFT reviewed May 19, 2023
View reviewed changes
toddysm
toddysm requested changes May 20, 2023
View reviewed changes
@yizha1
doc: update per comments
eb84a55 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from shizhMSFT May 20, 2023 13:00
@yizha1
update per comments
fd090fe 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from toddysm May 31, 2023 08:15
@yizha1
doc: update per comments
9b34231 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1
Copy link
Contributor Author

yizha1 commented Jun 5, 2023

@priteshbandi @toddysm could you re-review the spec again? The initial purpose of this PR is to remove the reference of Notary v2, for other issues found in this spec, suggest opening new issues accordingly, otherwise we couldn't close this PR, which has been open for quite some time.

shizhMSFT
shizhMSFT previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1
update per comments
b049e49 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested review from a user, FeynmanZhou and shizhMSFT August 1, 2023 08:52
@yizha1
update per comments
8a592fb 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost approved these changes Aug 1, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou
FeynmanZhou previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 mentioned this pull request Aug 2, 2023
Closed
@yizha1
update per comments
863549f 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 dismissed stale reviews from FeynmanZhou and shizhMSFT via 863549f August 2, 2023 05:43
@yizha1 yizha1 requested review from FeynmanZhou and shizhMSFT August 2, 2023 05:44
shizhMSFT
shizhMSFT approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou
FeynmanZhou approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1
Copy link
Contributor Author

yizha1 commented Aug 3, 2023

@gokarnm @priteshbandi Would you mind reviewing this PR?

@shizhMSFT shizhMSFT mentioned this pull request Aug 3, 2023
Closed
15 tasks
SteveLasker
SteveLasker approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit a3d1158 into notaryproject:main Aug 3, 2023
@yizha1 yizha1 deleted the update_spec branch August 3, 2023 23:30
priteshbandi
priteshbandi reviewed Aug 4, 2023
View reviewed changes
gokarnm
gokarnm reviewed Aug 5, 2023
View reviewed changes
gokarnm
gokarnm reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added a comment for a line that was removed, but that should not be a blocker.

@yizha1 yizha1 mentioned this pull request Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokarnm gokarnm gokarnm left review comments

@priteshbandi priteshbandi priteshbandi left review comments

@toddysm toddysm toddysm approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon

+3 more reviewers

@SteveLasker SteveLasker SteveLasker approved these changes

@TheFoxAtWork TheFoxAtWork TheFoxAtWork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update signature specification for v1.0.0 release Notation naming

9 participants

@yizha1 @toddysm @gokarnm @priteshbandi @SteveLasker @shizhMSFT @TheFoxAtWork @FeynmanZhou @iamsamirzon