Skip to content

chore: clean up #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from Jan 13, 2025
Merged

chore: clean up #502

1 commit merged into from Jan 13, 2025

Conversation

@ghost
Copy link

@ghost ghost commented Jan 9, 2025

While using the library, it's necessary for a further clean up:

  1. Fix comments with grammar issue.
  2. Fix 1 error message in blob trust policy.
  3. Removing/adding empty lines based on golang convention.

update
780aae1 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (26ce089) to head (780aae1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
verifier/verifier.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   80.46%   80.44%   -0.02%     
==========================================
  Files          35       35              
  Lines        3343     3340       -3     
==========================================
- Hits         2690     2687       -3     
  Misses        508      508              
  Partials      145      145

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JeyJeyGao
JeyJeyGao approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost mentioned this pull request Jan 9, 2025
Merged
shizhMSFT
shizhMSFT approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit b40566d into notaryproject:main Jan 13, 2025
9 checks passed
@ghost ghost deleted the blob branch January 13, 2025 23:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shizhMSFT @JeyJeyGao