Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 21, 2023

This PR adds Uninstall method to CLIManager.

Patrick Zheng added 3 commits November 20, 2023 17:05
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Patrick Zheng added 3 commits November 21, 2023 09:51
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ce0c457) 74.36% compared to head (b33af9d) 74.33%.

Files Patch % Lines
plugin/manager.go 66.66% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   74.36%   74.33%   -0.04%     
==========================================
  Files          24       24              
  Lines        2251     2260       +9     
==========================================
+ Hits         1674     1680       +6     
- Misses        457      459       +2     
- Partials      120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title feat: added uninstall to CLIManager feat: add uninstall to CLIManager Nov 23, 2023
@ghost ghost merged commit 5de0d58 into notaryproject:main Nov 23, 2023
@ghost ghost deleted the plugin branch November 23, 2023 03:15
@ghost ghost mentioned this pull request Jan 24, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants