Skip to content

bump: update oras-go to v2.3.0 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeyJeyGao merged 5 commits into from
Sep 15, 2023
Merged

bump: update oras-go to v2.3.0 #347

JeyJeyGao merged 5 commits into from
Sep 15, 2023

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Aug 31, 2023 •
edited
Loading

  • Update oras-go to v2.3.0.
  • Replace oras.Pack() with oras.PackManifest() as it is deprecated in v2.3.0.
  • Generate an empty config blob manually, as oras.PackManifest() does not generate the config blob with the notation artifact type as the media type.

Resolves #346
Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao
fix: update oras-go v2.3.0
e5457d1 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao requested a review from a user August 31, 2023 06:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #347 (0b41645) into main (f1706c2) will decrease coverage by 0.21%.
The diff coverage is 59.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   74.88%   74.68%   -0.21%     
==========================================
  Files          23       23              
  Lines        2210     2228      +18     
==========================================
+ Hits         1655     1664       +9     
- Misses        437      443       +6     
- Partials      118      121       +3
Files Changed Coverage Δ
registry/repository.go 49.41% <59.09%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeyJeyGao
fix: add comments
566c7fd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
ghost
ghost previously approved these changes Aug 31, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qweeah
qweeah reviewed Aug 31, 2023
View reviewed changes
@shizhMSFT shizhMSFT changed the title fix: update oras-go v2.3.0 bump: update oras-go to v2.3.0 Aug 31, 2023
shizhMSFT
shizhMSFT previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Wwwsylvia
Wwwsylvia suggested changes Aug 31, 2023
View reviewed changes
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and ghost via 9dfdb3b September 1, 2023 02:09
@JeyJeyGao
fix: update code
7e008e6 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao force-pushed the feat/update_oras_go_2.3.0 branch from 9dfdb3b to 7e008e6 Compare September 1, 2023 02:26
shizhMSFT
shizhMSFT previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost reviewed Sep 1, 2023
View reviewed changes
Wwwsylvia
Wwwsylvia approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
fix: update comment
0b41645 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Wwwsylvia
Wwwsylvia approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost approved these changes Sep 4, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Sep 5, 2023
Closed
Merged
priteshbandi
priteshbandi approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 60d9cdc into notaryproject:main Sep 15, 2023
@shizhMSFT shizhMSFT mentioned this pull request Oct 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

+3 more reviewers

@qweeah qweeah qweeah left review comments

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

oras-go updated v2.3.0

6 participants

@JeyJeyGao @codecov-commenter @qweeah @priteshbandi @Wwwsylvia @shizhMSFT