Skip to content

chore: add issue template#293

Merged
priteshbandi merged 8 commits intonotaryproject:mainfrom
yizha1:issue_temp
Jun 14, 2023
Merged

chore: add issue template#293
priteshbandi merged 8 commits intonotaryproject:mainfrom
yizha1:issue_temp

Conversation

@yizha1
Copy link
Copy Markdown
Contributor

@yizha1 yizha1 commented Mar 22, 2023

Add issue template for notation-go, which is copied from notation repo.

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 added the Governance issues to improve governance posture label Mar 22, 2023
@yizha1 yizha1 linked an issue Mar 22, 2023 that may be closed by this pull request
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #293 (06ff888) into main (9b0e472) will increase coverage by 0.00%.
The diff coverage is 76.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files          23       23           
  Lines        2179     2203   +24     
=======================================
+ Hits         1630     1648   +18     
- Misses        433      437    +4     
- Partials      116      118    +2     
Impacted Files Coverage Δ
verifier/trustpolicy/trustpolicy.go 91.48% <76.47%> (-0.77%) ⬇️
config/base.go 63.63% <76.92%> (+6.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from a user June 11, 2023 01:35
@yizha1 yizha1 added this to the 1.0.0 milestone Jun 11, 2023
@yizha1 yizha1 self-assigned this Jun 12, 2023
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from priteshbandi June 13, 2023 07:44
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from a user June 13, 2023 11:07
priteshbandi
priteshbandi previously approved these changes Jun 13, 2023
Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit fa4ddc8 into notaryproject:main Jun 14, 2023
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Governance issues to improve governance posture

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Create a bug report template for notation-go

3 participants