Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 29, 2024

Release

This would mean tagging 4700ad6 as v1.2.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation v1.2.0.

What's Changed

Full Changelog: v1.2.0-rc.1...4700ad6

Actions

Please review the PR and vote by approving.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@JeyJeyGao
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (8ad226c) to head (4700ad6).
Report is 2 commits behind head on release-1.2.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.2    #1022   +/-   ##
============================================
  Coverage        72.01%   72.01%           
============================================
  Files               46       46           
  Lines             2287     2287           
============================================
  Hits              1647     1647           
  Misses             440      440           
  Partials           200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Aug 29, 2024

LGTM

1 similar comment
@priteshbandi
Copy link
Contributor

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit e450002 into notaryproject:release-1.2 Aug 29, 2024
@ghost ghost deleted the release-1.2 branch August 29, 2024 06:16
@ghost ghost mentioned this pull request Sep 9, 2024
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants