Skip to content

fix(docs): remove blob signing docs for release-1.1 branch #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeyJeyGao merged 4 commits into from
Aug 21, 2024
Merged

fix(docs): remove blob signing docs for release-1.1 branch #1013

JeyJeyGao merged 4 commits into from
Aug 21, 2024

Conversation

@JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Aug 16, 2024 •
edited
Loading

Fix(docs):

  • we should remove blob signing docs for release-1.1 branch as the feature was not included in v1.1

Resolves #1012
Signed-off-by: Junjie Gao junjiegao@microsoft.com

@JeyJeyGao JeyJeyGao requested a review from a user August 16, 2024 03:19
@JeyJeyGao JeyJeyGao marked this pull request as draft August 16, 2024 03:22
@JeyJeyGao JeyJeyGao changed the title fix(docs): remove blob signing docs fix(docs): remove blob signing docs for release-1.1 branch Aug 16, 2024
@JeyJeyGao JeyJeyGao marked this pull request as ready for review August 16, 2024 04:14
shizhMSFT
shizhMSFT approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost approved these changes Aug 19, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
docs: remove blob signing docs
4c33528 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
efddf58 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
86012d4 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
786562d 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao merged commit 044f42f into notaryproject:release-1.1 Aug 21, 2024
@JeyJeyGao JeyJeyGao deleted the docs/remove_blob branch August 21, 2024 02:39
@JeyJeyGao JeyJeyGao mentioned this pull request Oct 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@vaninrao10 vaninrao10 vaninrao10 approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JeyJeyGao @priteshbandi @shizhMSFT @vaninrao10