This is already part of the NIP 44 PR: https://github.com/nostr-protocol/nips/pull/746/files

ah cool thanks.

should we add getKey for nip44 too?

I'm personally against it, I don't think it accomplishes anything that a well-optimized nip 07 extension can't.

Get key should be available on the Android Signer and the NIP-46 Signers. I think we should add to nip-07 just for consistency in case somebody is making a single app that uses all of the 3 signers at the same time.

yeah @pablof7z just added it to the nip46 rewrite pr which is what prompted me to open this. consistency was the main reason I wanted to add it too, but I also agree with @staab that it doesn't really accomplish anything.

+1

I'm with @vitorpamplona ; consistency is good and you can drive a truck through "well-optimized nip07 extension" 😅

I have reopened this in a new PR (github wasn't letting me reopen this one) #940

NIP07 updates were removed from NIP44 PR so opening this again to come to agreement on how nip07 should be updated

I haven't been able to track all the changes to this file and NIP 46 that have been proposed, what's the argument for getKey? The downside is that an evil client can exfiltrate conversation keys for all DMs, and since we have no forward secrecy or post-compromise security that gives them access to snoop forever.

Edit, ignore this, I'll re-post in the real PR.