NIP-39: moves i tags out of kind 0#2216
Merged
fiatjaf merged 1 commit intonostr-protocol:masterfrom Feb 10, 2026
Merged
Conversation
Contributor
|
I would prefer we don't modify 3 years old protocol. Nostria uses these tags and will continue to do so, I understand many clients doesn't use them, but some does and until here is any widespread adoption of kind 10011 for this, which there for very obvious reason will never be (given that there is lack of using it now), I'll continue to use kind 0 for "i" tags for external identities. This change is absolutely not needed. "Nobody" will use it (given your own words and evidence), so instead of simply leaving what is there, which some clients has already implemented, you introduce a massive backwards compatibility train for an extremely little used feature. I suggest reverting this PR. |
Contributor
|
I am neutral on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
itags, which almost nobody supports, from kind 0 to its own kind 10011.There is no point in growing the size of kind 0 with lots of tags nobody supports.
I feel like we can merge this faster since no one really supports these tags.
@Semisol