Skip to content

chore(appstore): fix scrolling on appstore background #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeroenptrs merged 1 commit into from
Mar 30, 2019
Merged

chore(appstore): fix scrolling on appstore background #948

jeroenptrs merged 1 commit into from
Mar 30, 2019

Conversation

@jeroenptrs
Copy link
Contributor

@jeroenptrs jeroenptrs commented Mar 30, 2019

Description

Scrolling on the background didn't work, this fixes it

Motivation and Context

Fix was needed

How Has This Been Tested?

Tested it by trying out scrolling

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@jeroenptrs jeroenptrs added the PR: needs review Pull request label Mar 30, 2019
@jeroenptrs jeroenptrs self-assigned this Mar 30, 2019
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Mar 30, 2019
@jeroenptrs jeroenptrs merged commit d259b9f into develop Mar 30, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fixScrollingOnAppStore branch March 30, 2019 16:47
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DalderupMaurice DalderupMaurice DalderupMaurice approved these changes

@deanpress deanpress Awaiting requested review from deanpress

Assignees

@jeroenptrs jeroenptrs

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeroenptrs @DalderupMaurice