Skip to content

feat(browser): new icons and exchange link #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeroenptrs merged 3 commits into from
Mar 30, 2019
Merged

feat(browser): new icons and exchange link #947

jeroenptrs merged 3 commits into from
Mar 30, 2019

Conversation

@jeroenptrs
Copy link
Contributor

@jeroenptrs jeroenptrs commented Mar 30, 2019

Description

Adds new icons and enables Nash as exchange in the sidebar. Also changed the order of the sidebar.

Motivation and Context

With Nash launching soon it makes sense to enable the exchange part of the nOS browser.

How Has This Been Tested?

Imported the icons and looked if they're ok

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@jeroenptrs jeroenptrs added the PR: needs review Pull request label Mar 30, 2019
@jeroenptrs jeroenptrs self-assigned this Mar 30, 2019
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #947 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #947      +/-   ##
==========================================
+ Coverage    52.47%   52.5%   +0.02%     
==========================================
  Files          240     240              
  Lines         2039    2040       +1     
  Branches       277     278       +1     
==========================================
+ Hits          1070    1071       +1     
  Misses         802     802              
  Partials       167     167

1 similar comment
@codecov
Copy link

codecov bot commented Mar 30, 2019

Codecov Report

Merging #947 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #947      +/-   ##
==========================================
+ Coverage    52.47%   52.5%   +0.02%     
==========================================
  Files          240     240              
  Lines         2039    2040       +1     
  Branches       277     278       +1     
==========================================
+ Hits          1070    1071       +1     
  Misses         802     802              
  Partials       167     167

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Mar 30, 2019
@jeroenptrs jeroenptrs merged commit 00406ec into develop Mar 30, 2019
@jeroenptrs jeroenptrs deleted the feat/newIcons branch March 30, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DalderupMaurice DalderupMaurice DalderupMaurice approved these changes

@deanpress deanpress Awaiting requested review from deanpress

Assignees

@jeroenptrs jeroenptrs

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeroenptrs @DalderupMaurice