Skip to content

Conversation

@jeroenptrs
Copy link
Contributor

@jeroenptrs jeroenptrs commented Mar 29, 2019

Description

App store view

Motivation and Context

This adds a new native window that displays a list of apps and tools available on nOS

How Has This Been Tested?

Testing and displaying API responses

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@jeroenptrs jeroenptrs added the PR: needs review Pull request label Mar 29, 2019
@jeroenptrs jeroenptrs self-assigned this Mar 29, 2019
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #945 into develop will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
- Coverage    52.35%   52.29%   -0.06%     
===========================================
  Files          236      236              
  Lines         2021     2023       +2     
  Branches       277      277              
===========================================
  Hits          1058     1058              
- Misses         796      798       +2     
  Partials       167      167

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #945 into develop will increase coverage by 0.12%.
The diff coverage is 68.42%.

@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
+ Coverage    52.35%   52.47%   +0.12%     
===========================================
  Files          236      240       +4     
  Lines         2021     2039      +18     
  Branches       277      277              
===========================================
+ Hits          1058     1070      +12     
- Misses         796      802       +6     
  Partials       167      167

@codecov-io
Copy link

Codecov Report

Merging #945 into develop will increase coverage by 0.12%.
The diff coverage is 68.42%.

@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
+ Coverage    52.35%   52.47%   +0.12%     
===========================================
  Files          236      240       +4     
  Lines         2021     2039      +18     
  Branches       277      277              
===========================================
+ Hits          1058     1070      +12     
- Misses         796      802       +6     
  Partials       167      167

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #945 into develop will increase coverage by 0.12%.
The diff coverage is 68.42%.

@@             Coverage Diff             @@
##           develop     #945      +/-   ##
===========================================
+ Coverage    52.35%   52.47%   +0.12%     
===========================================
  Files          236      240       +4     
  Lines         2021     2039      +18     
  Branches       277      277              
===========================================
+ Hits          1058     1070      +12     
- Misses         796      802       +6     
  Partials       167      167

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Mar 29, 2019
@jeroenptrs jeroenptrs merged commit 83dfd1c into develop Mar 29, 2019
@jeroenptrs jeroenptrs deleted the feat/appStore branch March 29, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants