-
Notifications
You must be signed in to change notification settings - Fork 70
feat(account): add ability to browse the client as a guest #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanpress
reviewed
Mar 10, 2019
deanpress
reviewed
Mar 10, 2019
Codecov Report
@@ Coverage Diff @@
## develop #898 +/- ##
===========================================
- Coverage 52.5% 51.22% -1.28%
===========================================
Files 240 236 -4
Lines 2040 2005 -35
Branches 278 262 -16
===========================================
- Hits 1071 1027 -44
- Misses 802 817 +15
+ Partials 167 161 -6 |
- fix pill margin - cleanup register store after registration - fix compile issue - hide adding new addresses for ledger
- Added storing of latest signed in account after registration/login for ease of use - fixed bug where new registered account didnt show up in modal - Adjust error messages - Fixed issue where old balances where still present when logging out and back in with another account
- fixed ledger registration/login not working - fixed an issue where error messages where not shown on the registration completion step
- Remove dedundant settings word - Set max length to secret word - Rename secret word to seed word in verification screen - keep register form data when going back
- reset RegisterformData when signing in - disable button at registration completion page when loading and add form validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #