Skip to content

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Feb 26, 2019

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice marked this pull request as ready for review July 17, 2019 18:19
@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #898 into develop will decrease coverage by 1.27%.
The diff coverage is 42.7%.

@@             Coverage Diff             @@
##           develop     #898      +/-   ##
===========================================
- Coverage     52.5%   51.22%   -1.28%     
===========================================
  Files          240      236       -4     
  Lines         2040     2005      -35     
  Branches       278      262      -16     
===========================================
- Hits          1071     1027      -44     
- Misses         802      817      +15     
+ Partials       167      161       -6

Maurice Dalderup added 14 commits July 17, 2019 21:36
- fix pill margin
- cleanup register store after registration
- fix compile issue
- hide adding new addresses for ledger
- Added storing of latest signed in account after registration/login for ease of use
- fixed bug where new registered account didnt show up in modal
- Adjust error messages
- Fixed issue where old balances where still present when logging out and back in with another account
- fixed ledger registration/login not working
- fixed an issue where error messages where not shown on the registration completion step
- Remove dedundant settings word
- Set max length to secret word
- Rename secret word to seed word in verification screen
- keep register form data when going back
- reset RegisterformData when signing in
- disable button at registration completion page when loading and add form validation
@DalderupMaurice DalderupMaurice merged commit 48f54b0 into develop Jul 20, 2019
@DalderupMaurice DalderupMaurice deleted the feat/remove-login branch July 20, 2019 17:36
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jul 20, 2019
@DalderupMaurice DalderupMaurice restored the feat/remove-login branch July 23, 2019 14:34
@DalderupMaurice DalderupMaurice deleted the feat/remove-login branch July 23, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants