Skip to content

feat(portfolio): added auto fetch of balances upon new block #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 7 commits into from
Jul 9, 2020
Merged

feat(portfolio): added auto fetch of balances upon new block #1322

DalderupMaurice merged 7 commits into from
Jul 9, 2020

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jun 21, 2020 •
edited
Loading

Description

  • Added auto fetch of balances upon new block
  • Added display of NOS when interaction with NOS smart contract
  • Fix Snyk issue
  • Bump node version

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #1322 into develop will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop    #1322      +/-   ##
===========================================
- Coverage    49.55%   49.53%   -0.03%     
===========================================
  Files          249      249              
  Lines         2139     2150      +11     
  Branches       285        0     -285     
===========================================
+ Hits          1060     1065       +5     
- Misses         898     1085     +187     
+ Partials       181        0     -181

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Jul 9, 2020
@DalderupMaurice DalderupMaurice merged commit 03d120d into develop Jul 9, 2020
@DalderupMaurice DalderupMaurice deleted the origin/fetch-balances branch July 9, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DalderupMaurice