Skip to content

chore(app): removed logout button when not signed in #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 2 commits into from
Aug 15, 2019
Merged

chore(app): removed logout button when not signed in #1098

DalderupMaurice merged 2 commits into from
Aug 15, 2019

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Aug 15, 2019 •
edited
Loading

Description

removes the logout button when you're not authenicated

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Aug 15, 2019 •
edited
Loading

Codecov Report

Merging #1098 into develop will decrease coverage by 0.04%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #1098      +/-   ##
===========================================
- Coverage    50.82%   50.77%   -0.05%     
===========================================
  Files          240      240              
  Lines         2064     2062       -2     
  Branches       275      275              
===========================================
- Hits          1049     1047       -2     
  Misses         843      843              
  Partials       172      172

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 15, 2019
jeroenptrs
jeroenptrs approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@jeroenptrs jeroenptrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, will test in a bit
LGTM

@jeroenptrs jeroenptrs added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 15, 2019
@DalderupMaurice DalderupMaurice merged commit fd72408 into develop Aug 15, 2019
@DalderupMaurice DalderupMaurice deleted the chore/remove-logout-btn branch August 15, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeroenptrs jeroenptrs jeroenptrs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DalderupMaurice @jeroenptrs