Skip to content

chore(appContainer): adds a default bg color to the webview page #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 1 commit into from
Aug 10, 2019
Merged

chore(appContainer): adds a default bg color to the webview page #1071

DalderupMaurice merged 1 commit into from
Aug 10, 2019

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Aug 8, 2019 •
edited
Loading

Description

Adds a default bg color to the webview page.

Viewing js/json/files in common in the nOS Browser has a weird gray color by default, rendering text not readable.
This PR fixes this by setting a default color as white for these pages.

Motivation and Context

Text of files was unreadable

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 8, 2019
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #1071 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1071   +/-   ##
========================================
  Coverage    51.04%   51.04%           
========================================
  Files          238      238           
  Lines         2061     2061           
  Branches       275      275           
========================================
  Hits          1052     1052           
  Misses         838      838           
  Partials       171      171

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 10, 2019
@DalderupMaurice DalderupMaurice merged commit 2d4f129 into develop Aug 10, 2019
@DalderupMaurice DalderupMaurice deleted the chore/bg-for-pages branch August 10, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanpress deanpress deanpress approved these changes

@jeroenptrs jeroenptrs Awaiting requested review from jeroenptrs

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DalderupMaurice @deanpress