Skip to content

chore(buttonBar): adjusted hover state colors of buttonbar #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 2 commits into from
Aug 6, 2019
Merged

chore(buttonBar): adjusted hover state colors of buttonbar #1067

DalderupMaurice merged 2 commits into from
Aug 6, 2019

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Aug 6, 2019 •
edited
Loading

Description

Adjusts the colors of the min-max button hover and click states

Motivation and Context

Colors were not really well visible

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 6, 2019
@codecov
Copy link

codecov bot commented Aug 6, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@0634777). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1067   +/-   ##
==========================================
  Coverage           ?   50.94%           
==========================================
  Files              ?      238           
  Lines              ?     2055           
  Branches           ?      274           
==========================================
  Hits               ?     1047           
  Misses             ?      837           
  Partials           ?      171

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 6, 2019
@DalderupMaurice DalderupMaurice merged commit 0a16086 into develop Aug 6, 2019
@DalderupMaurice DalderupMaurice deleted the chore/min-max-buttons-contrast branch August 6, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeroenptrs jeroenptrs jeroenptrs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DalderupMaurice @jeroenptrs