Skip to content

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Aug 5, 2019

Description

The API still believed the "address" attribute was directly exposed in the auth object. Which isn't the case anymore as it's moved under the "wallet" attribute of the auth object.

This PR fixes that issue

Motivation and Context

API wasn't able to utilize the user's address

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@DalderupMaurice DalderupMaurice added the PR: needs review Pull request label Aug 5, 2019
@jeroenptrs jeroenptrs added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 6, 2019
@DalderupMaurice DalderupMaurice merged commit b8111e4 into develop Aug 6, 2019
@DalderupMaurice DalderupMaurice deleted the chore/api-fixes branch August 6, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants