Skip to content

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Aug 2, 2019

Description

It was possible to click the already active wallet.
This PR disables the popup from showing up and removes the hover of the already active wallet

Motivation and Context

Bad UX

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1054 into develop will decrease coverage by 0.12%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #1054      +/-   ##
===========================================
- Coverage    51.15%   51.02%   -0.13%     
===========================================
  Files          238      238              
  Lines         2041     2046       +5     
  Branches       269      271       +2     
===========================================
  Hits          1044     1044              
- Misses         830      833       +3     
- Partials       167      169       +2

Copy link
Contributor

@jeroenptrs jeroenptrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeroenptrs jeroenptrs added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Aug 2, 2019
@DalderupMaurice DalderupMaurice merged commit 0673025 into develop Aug 2, 2019
@DalderupMaurice DalderupMaurice deleted the chore/disable-click-primary-wallet branch August 2, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants