chore(browser): remove "bump" next to the browser #1049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AuthenticatedLayout's content element had a 4px bump next to it (mostly visible on scrollable content). This hardwires the content's width to the max it's allowed (viewport - sidebar) and casts overflow to auto. This is needed for internal pages (app store) that rely on native content scrolling. Scrolling in webpages inherits from the webpage itself (i.e. if the content should scroll, it will scroll.)
Note: for some reason using $sidebar-width in $content-width doesn't work 🙂
Motivation and Context
Fix UI mistakes detected by @deanpress on dark/light mode switching
How Has This Been Tested?
A/B'd with internal pages and external pages (nos.chat, nash, ...)
Screenshots (if appropriate)
Types of changes
Checklist
Documentation
Closing issues
Fixes #