Skip to content

Conversation

@jeroenptrs
Copy link
Contributor

Description

AuthenticatedLayout's content element had a 4px bump next to it (mostly visible on scrollable content). This hardwires the content's width to the max it's allowed (viewport - sidebar) and casts overflow to auto. This is needed for internal pages (app store) that rely on native content scrolling. Scrolling in webpages inherits from the webpage itself (i.e. if the content should scroll, it will scroll.)

Note: for some reason using $sidebar-width in $content-width doesn't work 🙂

Motivation and Context

Fix UI mistakes detected by @deanpress on dark/light mode switching

How Has This Been Tested?

A/B'd with internal pages and external pages (nos.chat, nash, ...)

Screenshots (if appropriate)

image

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@jeroenptrs jeroenptrs added the PR: needs review Pull request label Jul 31, 2019
@jeroenptrs jeroenptrs added this to the 0.6.0 milestone Jul 31, 2019
@jeroenptrs jeroenptrs self-assigned this Jul 31, 2019
@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@be79e6e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1049   +/-   ##
==========================================
  Coverage           ?   51.48%           
==========================================
  Files              ?      237           
  Lines              ?     2016           
  Branches           ?      267           
==========================================
  Hits               ?     1038           
  Misses             ?      813           
  Partials           ?      165

@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: needs review Pull request labels Jul 31, 2019
@DalderupMaurice DalderupMaurice merged commit ce50ab3 into develop Jul 31, 2019
@DalderupMaurice DalderupMaurice deleted the chore/fix-sidebar-track branch July 31, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants