Skip to content

feat(management): add ability to change the active wallet #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 8 commits into from
Aug 2, 2019
Merged

feat(management): add ability to change the active wallet #1048

DalderupMaurice merged 8 commits into from
Aug 2, 2019

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jul 29, 2019 •
edited
Loading

Description

Added the ability to change the currently active wallet

Motivation and Context

There's no point of having multiple wallets when you cannot activate/use them

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #609

@codecov
Copy link

codecov bot commented Jul 29, 2019 •
edited
Loading

Codecov Report

Merging #1048 into develop will decrease coverage by 0.33%.
The diff coverage is 22.22%.

@@             Coverage Diff             @@
##           develop    #1048      +/-   ##
===========================================
- Coverage    51.48%   51.15%   -0.34%     
===========================================
  Files          237      238       +1     
  Lines         2016     2041      +25     
  Branches       267      269       +2     
===========================================
+ Hits          1038     1044       +6     
- Misses         813      830      +17     
- Partials       165      167       +2

@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Jul 30, 2019
@DalderupMaurice DalderupMaurice added PR: don't merge This doesn't seem right and removed PR: good to merge Reviewed and approved labels Jul 31, 2019
@DalderupMaurice DalderupMaurice added PR: good to merge Reviewed and approved and removed PR: don't merge This doesn't seem right labels Aug 2, 2019
@DalderupMaurice DalderupMaurice merged commit c6bc0be into develop Aug 2, 2019
@DalderupMaurice DalderupMaurice deleted the feat/change-active-wallet branch August 2, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support multiple ledger accounts

2 participants

@DalderupMaurice