Skip to content

chore(send): disable ability to send empty transactions #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DalderupMaurice merged 1 commit into from
Jul 21, 2019
Merged

chore(send): disable ability to send empty transactions #1028

DalderupMaurice merged 1 commit into from
Jul 21, 2019

Conversation

@DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Jul 21, 2019 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING guidelines and confirm that my code follows the code style of this project.
  • Tests for the changes have been added (for bug fixes/features)

Documentation

  • Docs need to be added/updated (for bug fixes/features)

Closing issues

Fixes #

@codecov
Copy link

codecov bot commented Jul 21, 2019

Codecov Report

Merging #1028 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1028      +/-   ##
===========================================
+ Coverage    51.26%   51.29%   +0.02%     
===========================================
  Files          236      236              
  Lines         2011     2014       +3     
  Branches       266      265       -1     
===========================================
+ Hits          1031     1033       +2     
  Misses         817      817              
- Partials       163      164       +1

@DalderupMaurice DalderupMaurice merged commit d6d3ae5 into develop Jul 21, 2019
@DalderupMaurice DalderupMaurice deleted the chore/disable-empty-tx branch July 21, 2019 10:19
@DalderupMaurice DalderupMaurice added the PR: good to merge Reviewed and approved label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: good to merge Reviewed and approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DalderupMaurice