Skip to content

feat: display status during task execution #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lingjiefeng merged 3 commits into from
Apr 25, 2024
Merged

feat: display status during task execution #141

lingjiefeng merged 3 commits into from
Apr 25, 2024

Conversation

@lingjiefeng
Copy link
Contributor

@lingjiefeng lingjiefeng commented Apr 23, 2024 •
edited
Loading

Description

resolve #138

Displays 7 status during task execution:

  • Idle
  • Attaching Debugger
  • Understanding Website (one for text based dom pulling, one for vision based web annotation)
  • Getting Instructions
  • Thinking and planning
  • Performing Action
  • Waiting

Type of Change

  • New feature (non-breaking change which adds functionality)

Demo

status_demo.mov

@lingjiefeng lingjiefeng requested a review from mondaychen as a code owner April 23, 2024 20:41
@lingjiefeng lingjiefeng requested a review from cemigo114 April 23, 2024 20:43
mondaychen
mondaychen approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mondaychen mondaychen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/common/TaskStatus.tsx Outdated
idle: "💤 Idle",
"attaching-debugger": "🔗 Attaching Debugger",
"pulling-dom": "🌐 Understanding Website",
"annotating-web": "🌐 Understanding Website",
Copy link
Contributor

@mondaychen mondaychen Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe annotating page? It’s a bit weird to just call it web

@lingjiefeng
Copy link
Contributor Author

lingjiefeng commented Apr 25, 2024

(great suggestion from Yuchen)
For future V2 as we refine:
Add stage completion (e.g. stage 1/4: thinking and planning completed) so users know roughly where they are in the whole process "should I grab a coffee for a few minutes while waiting or go for a walk for a few hours?"
For long (e.g. more than 10 seconds) process, while users are waiting, keep them engaged with tips and things they can learn about WebWand

@lingjiefeng lingjiefeng merged commit 00cc6a5 into main Apr 25, 2024
@mondaychen mondaychen mentioned this pull request Apr 25, 2024
Closed
@mondaychen mondaychen deleted the lynchee/status branch May 23, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mondaychen mondaychen mondaychen approved these changes

@cemigo114 cemigo114 Awaiting requested review from cemigo114

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show task status in UI

3 participants

@lingjiefeng @mondaychen