[Backport into 5.21] disable HAC + set noobaa-core term grace to 1#1763
Merged
liranmauda merged 2 commits intonoobaa:5.21from Jan 7, 2026
Merged
[Backport into 5.21] disable HAC + set noobaa-core term grace to 1#1763liranmauda merged 2 commits intonoobaa:5.21from
liranmauda merged 2 commits intonoobaa:5.21from
Conversation
- HAC can be enabled with the env HAC_ENABLED=true - Also changed the default grace period of the HAC when enabled from 0 to 1. This change avoids force deletion of the pods, to prevent multiple containers running concurrently. - The grace period can be set to 0 with the env HAC_FORCE_DELETE=true - Also setting the terminationGracePeriodSeconds of noobaa-core to 1. By default this is 30 seconds. Since we don't have any handler in noobaa-core for SIGETRM, there isn't a need to wait 30 seconds before killing the container. Signed-off-by: Danny Zaken <dannyzaken@gmail.com> (cherry picked from commit 38294af)
Signed-off-by: Danny Zaken <dannyzaken@gmail.com> (cherry picked from commit 5e2d253)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dannyzaken
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx