Skip to content

Delete pre-commit#1742

Merged
jackyalbo merged 1 commit intonoobaa:masterfrom
jackyalbo:jacky-operator-fix1
Dec 3, 2025
Merged

Delete pre-commit#1742
jackyalbo merged 1 commit intonoobaa:masterfrom
jackyalbo:jacky-operator-fix1

Conversation

@jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Dec 3, 2025 •
edited by coderabbitai bot
Loading

Explain the changes

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

Summary by CodeRabbit

  • Chores
    • Removed pre-commit validation configuration

✏️ Tip: You can customize this high-level summary in your review settings.

@jackyalbo
Delete pre-commit
84b7c69 
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

This PR removes the .githooks/pre-commit shell hook that previously executed golangci-lint on staged Go files. The hook computed the script directory and project root, then invoked the unified golangci-lint script in precommit mode.

Changes

Cohort / File(s) Summary
Pre-commit Hook Removal
.githooks/pre-commit		 Deleted pre-commit shell hook that ran golangci-lint on staged Go files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

size/M

Suggested reviewers

  • liranmauda
  • achouhan09

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description uses the required template structure but all content sections are empty with only placeholder text, providing no substantive information about the changes. Fill in the 'Explain the changes' section with details about why the pre-commit hook was removed, reference any related issues, and provide testing instructions or clarification if no testing is needed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Delete pre-commit' accurately describes the main change of removing the pre-commit shell hook from .githooks/pre-commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc1bf2f and 84b7c69.

📒 Files selected for processing (1)
  • .githooks/pre-commit (0 hunks)
💤 Files with no reviewable changes (1)
  • .githooks/pre-commit
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: run-cli-tests
  • GitHub Check: run-kms-key-rotate-test
  • GitHub Check: run-kms-tls-sa-test
  • GitHub Check: cnpg-deployment-test
  • GitHub Check: run-kms-tls-token-test
  • GitHub Check: run-hac-test
  • GitHub Check: run-admission-test
  • GitHub Check: run-core-config-map-tests
  • GitHub Check: run-kms-kmip-test
  • GitHub Check: run-operator-tests
  • GitHub Check: golangci-lint
  • GitHub Check: run-kms-dev-test
  • GitHub Check: run-azure-vault-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

nadavMiz
nadavMiz approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@nadavMiz nadavMiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackyalbo jackyalbo merged commit be3b476 into noobaa:master Dec 3, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nadavMiz nadavMiz nadavMiz approved these changes

@nimrod-becker nimrod-becker Awaiting requested review from nimrod-becker

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackyalbo @nadavMiz