Skip to content

Increased cnpg operator memory to 300Mi#1741

Merged
dannyzaken merged 1 commit intonoobaa:masterfrom
dannyzaken:danny-fixes
Dec 3, 2025
Merged

Increased cnpg operator memory to 300Mi#1741
dannyzaken merged 1 commit intonoobaa:masterfrom
dannyzaken:danny-fixes

Conversation

@dannyzaken
Copy link
Member

@dannyzaken dannyzaken commented Dec 3, 2025 •
edited
Loading

Explain the changes

  1. Increased cnpg operator memory to 300Mi in OLM deployments

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/DFBUGS-4545

Testing Instructions:

  • Doc added/updated
  • Tests added

Summary by CodeRabbit

  • Bug Fixes
    • Configured resource limits and requests for the CNPG operator to enhance stability and prevent excessive resource consumption in cluster environments.

✏️ Tip: You can customize this high-level summary in your review settings.

@dannyzaken
increased cnpg operator memory to 300Mi
640cb4e 
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025 •
edited
Loading

Walkthrough

Added import for resource package and configured resource requirements (CPU 100m, Memory 300Mi limits and requests) for the CNPG operator container in the addCnpgToCSV function.

Changes

Cohort / File(s) Summary
CNPG operator resource configuration
pkg/olm/olm.go		 Added import k8s.io/apimachinery/pkg/api/resource. Set container resource limits and requests (CPU 100m, Memory 300Mi) for the CNPG operator's first container in the deployment template.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that resource values (CPU 100m, Memory 300Mi) are appropriate for CNPG operator workload
  • Confirm the import is correctly used and no unused imports exist
  • Check that resource configuration is applied to the correct container in the deployment spec

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The PR description follows the required template but is incomplete—Testing Instructions section is empty. Provide detailed testing instructions explaining how to verify the memory increase works correctly in OLM deployments, or confirm if this change requires no manual testing.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: increased CNPG operator memory allocation to 300Mi, which is clearly reflected in the code changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dannyzaken dannyzaken requested a review from liranmauda December 3, 2025 11:14
@dannyzaken dannyzaken merged commit cc1bf2f into noobaa:master Dec 3, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liranmauda liranmauda liranmauda approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannyzaken @liranmauda