Skip to content

Update AWS Regions with ap-southeast-6#1735

Merged
liranmauda merged 1 commit intonoobaa:masterfrom
liranmauda:liran-adding-regions
Nov 30, 2025
Merged

Update AWS Regions with ap-southeast-6#1735
liranmauda merged 1 commit intonoobaa:masterfrom
liranmauda:liran-adding-regions

Conversation

@liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Nov 30, 2025 •
edited by coderabbitai bot
Loading

Explain the changes

  • Update AWS Regions with ap-southeast-6

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/DFBUGS-4019

Summary by CodeRabbit

  • Bug Fixes
    • Added support for the ap-southeast-6 AWS region, making it available for configuration and selection.

✏️ Tip: You can customize this high-level summary in your review settings.

@liranmauda
Update AWS Regions with ap-southeast-6
3d230c5 
- Update AWS Regions with ap-southeast-6

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda requested a review from shirady November 30, 2025 11:28
@coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2025 •
edited
Loading

Walkthrough

A mapping entry for "ap-southeast-6" is added to the AWS region lookup map in pkg/util/util.go, enabling recognition of this region within the GetAWSRegion function's region deduction logic.

Changes

Cohort / File(s) Summary
AWS Region Mapping
pkg/util/util.go		 Added mapping entry for "ap-southeast-6" in the GetAWSRegion region lookup map, replacing a prior comment indicating the region was absent.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single data entry addition to a region map with no logic changes or error handling modifications required.

Possibly related PRs

Suggested reviewers

  • nadavMiz

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the required 'Explain the changes' and 'Issues' sections, but is missing the 'Testing Instructions' section and checkboxes for doc/test status. Add the 'Testing Instructions' section with clear testing steps and complete the documentation and testing checkboxes to fully comply with the template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update AWS Regions with ap-southeast-6' directly matches the main change: adding the ap-southeast-6 region mapping to the AWS region lookup.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6de7e1a and 3d230c5.

📒 Files selected for processing (1)
  • pkg/util/util.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: run-operator-tests
  • GitHub Check: run-kms-tls-token-test
  • GitHub Check: run-azure-vault-test
  • GitHub Check: cnpg-deployment-test
  • GitHub Check: run-kms-dev-test
  • GitHub Check: run-kms-kmip-test
  • GitHub Check: run-cli-tests
  • GitHub Check: run-core-config-map-tests
  • GitHub Check: run-kms-key-rotate-test
  • GitHub Check: run-admission-test
  • GitHub Check: run-hac-test
  • GitHub Check: golangci-lint
  • GitHub Check: run-kms-tls-sa-test
🔇 Additional comments (1)
pkg/util/util.go (1)

1240-1240: LGTM! The addition follows the correct pattern and is properly placed in alphabetical order within the AWS region map. ap-southeast-6 (Asia Pacific — New Zealand) is a valid AWS region that launched on September 2, 2025.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@liranmauda liranmauda merged commit 7396ac6 into noobaa:master Nov 30, 2025
16 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shirady shirady shirady approved these changes

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liranmauda @shirady