Merged
Conversation
Update rook api Signed-off-by: liranmauda <liran.mauda@gmail.com>
WalkthroughUpdates the NooBaa CRD YAML descriptions (not schema), changing affinity weight description and feature-gate wording, and bumps numerous dependencies in go.mod. The embedded CRD SHA256 in the bundle is updated to match the CRD content. Changes
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
deploy/crds/noobaa.io_noobaas.yaml(6 hunks)go.mod(6 hunks)pkg/bundle/deploy.go(7 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-07T07:50:45.559Z
Learnt from: liranmauda
PR: noobaa/noobaa-operator#1687
File: scripts/run-golangci-lint.sh:48-56
Timestamp: 2025-09-07T07:50:45.559Z
Learning: In the noobaa-operator repository, the maintainer liranmauda has confirmed that Go files with spaces in their names are not present and will never be allowed. Shellcheck warnings about word splitting in filename handling can be ignored when they relate to this edge case, as the added complexity for handling spaces is not justified.
Applied to files:
go.mod
📚 Learning: 2025-09-02T11:05:25.671Z
Learnt from: Neon-White
PR: noobaa/noobaa-operator#0
File: :0-0
Timestamp: 2025-09-02T11:05:25.671Z
Learning: In the noobaa-operator repository, the golangci-lint timeout is configured in `.golangci.yml` under `run.timeout` and is set to 5 minutes.
Applied to files:
go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: run-kms-kmip-test
- GitHub Check: run-cli-tests
- GitHub Check: run-operator-tests
- GitHub Check: run-kms-tls-token-test
- GitHub Check: run-kms-key-rotate-test
- GitHub Check: golangci-lint
- GitHub Check: run-kms-dev-test
- GitHub Check: run-admission-test
- GitHub Check: run-hac-test
- GitHub Check: run-kms-tls-sa-test
- GitHub Check: run-azure-vault-test
- GitHub Check: cnpg-deployment-test
- GitHub Check: run-core-config-map-tests
Comment on lines
+637
to
639
| compute a sum by iterating through the elements of this field and subtracting | ||
| "weight" from the sum if the node has pods which matches the corresponding podAffinityTerm; the | ||
| node(s) with the highest sum are the most preferred. |
There was a problem hiding this comment.
Undo the subtract phrasing change for pod anti-affinity weights.
Kubernetes still adds each matched weight to the node’s score for both affinity and anti-affinity terms; the scheduler does not subtract the weight. The new wording misrepresents upstream behavior and will mislead users configuring placement. Please revert to the original “adding weight” description so the CRD matches the actual scheduler semantics.(github.com)
🤖 Prompt for AI Agents
In deploy/crds/noobaa.io_noobaas.yaml around lines 637 to 639, the CRD
description incorrectly says the scheduler "subtracts" pod anti-affinity weight
when computing node scores; change the wording back to state that the scheduler
"adds" each matched weight to the node’s score (i.e., it sums and adds weights
for both affinity and anti-affinity terms) so the CRD matches upstream
Kubernetes scheduler semantics and documentation.
Comment on lines
+3
to
+5
| go 1.24.3 | ||
|
|
||
| toolchain go1.24.7 |
There was a problem hiding this comment.
Fix the go directive version format.
go directives accept only the major.minor release (e.g., 1.24), not a patch-level value. Leaving go 1.24.3 makes go commands fail immediately with invalid go version "1.24.3". Please drop the patch component so the module remains buildable.(github.com)
Apply this diff:
-go 1.24.3
+go 1.24📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| go 1.24.3 | |
| toolchain go1.24.7 | |
| go 1.24 | |
| toolchain go1.24.7 |
🤖 Prompt for AI Agents
In go.mod around lines 3 to 5, the go directive currently uses a patch-level
version ("go 1.24.3") which is invalid; update the go directive to the
major.minor form ("go 1.24") while leaving the toolchain line ("toolchain
go1.24.7") unchanged so module files are valid and go commands succeed.
nimrod-becker
approved these changes
Sep 29, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Update rook api
Summary by CodeRabbit
Documentation
Chores