Bumping version from 5.20.0 to 5.21.0#1704
Conversation
Bumping version from 5.20.0 to 5.21.0 Signed-off-by: liranmauda <liran.mauda@gmail.com>
WalkthroughBumps project version from 5.20.0 to 5.21.0 across code and documentation: updates exported/version constants and README-displayed defaults for images and CLI output. No logic or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
157-158: Bumped image flags to 5.21.0 — verified; update/remove the outdated "taken from branch 5.16" notes.No 5.20.0 references found; version constants and README image flags show 5.21.0 (version/version.go, pkg/bundle/deploy.go). Update/remove the misleading lines at README.md:129 and README.md:171.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(2 hunks)pkg/bundle/deploy.go(1 hunks)version/version.go(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-14T10:59:21.959Z
Learnt from: Neon-White
PR: noobaa/noobaa-operator#1587
File: pkg/system/reconciler.go:287-291
Timestamp: 2025-07-14T10:59:21.959Z
Learning: NooBaa operator design constraint: Multiple NooBaa instances are not supported in the same namespace, only across different namespaces. This means hard-coded resource names like ConfigMaps are acceptable within a namespace scope.
Applied to files:
README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: run-hac-test
- GitHub Check: run-kms-key-rotate-test
- GitHub Check: run-kms-kmip-test
- GitHub Check: cnpg-deployment-test
- GitHub Check: run-admission-test
- GitHub Check: run-kms-tls-token-test
- GitHub Check: run-kms-dev-test
- GitHub Check: run-core-config-map-tests
- GitHub Check: golangci-lint
- GitHub Check: run-azure-vault-test
- GitHub Check: run-operator-tests
- GitHub Check: run-kms-tls-sa-test
- GitHub Check: run-cli-tests
🔇 Additional comments (3)
version/version.go (1)
5-5: LGTM — version bumped to 5.21.0; verification complete.
- No "5.20.0" occurrences found repo-wide.
- No unexpected reassignments of the top-level version var; the only assignment outside version/version.go is the generated pkg/bundle/deploy.go:
const Version = "5.21.0"(written by pkg/bundler/bundler.go). Other matches are reads or field assignments (e.g., csv.Spec.Version.Version).- README.md contains expected 5.21.0 image/CLI strings.
After merge: tag v5.21.0 and publish images/release notes as needed.
pkg/bundle/deploy.go (1)
3-3: Version bump OK — repo-wide verification inconclusivepkg/bundle/deploy.go updated to 5.21.0; the repo-wide rg run returned "No files were searched", so verification didn't complete. Re-run this corrected sanity check locally or in CI to confirm no stale 5.20.0 strings remain:
#!/bin/bash set -euo pipefail echo "Searching for old and new versions..." rg -nP --hidden -g '!.git/**' '\b5\.20\.0\b' || echo "No 5.20.0 occurrences found." rg -nP --hidden -g '!.git/**' '\b5\.21\.0\b' || echo "No 5.21.0 occurrences found (verify expected files updated)." echo "Common spots to double-check:" rg -nP --hidden -g '!.git/**' -C2 '(Version\s*=|image:|tag:|NooBaa (Core|Operator) Version)' || trueREADME.md (1)
180-182: CLI version example updated — confirm built CLI prints 5.21.0.README shows the expected output at README.md:180–182. Source sets Version = "5.21.0" (version/version.go:5). Cannot run the compiled binary here; run the built CLI and confirm it prints those three lines.
Explain the changes
Bumping version from 5.20.0 to 5.21.0
Summary by CodeRabbit