CVE fix | Remove user_setup script#1701
Merged
liranmauda merged 1 commit intonoobaa:masterfrom Sep 16, 2025
Merged
Conversation
WalkthroughRemoved the build-time step that copied and ran Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Docker Build
participant Img as Image
participant Ctr as Container Runtime
rect rgba(230,240,255,0.5)
note over Dev,Img: Build-time (updated)
Dev->>Img: COPY operator binary (`${NOOBAA_BIN_PATH}` → `${OPERATOR}`)
note over Dev,Img: Previously also copied `build/bin/user_setup` and ran it (removed)
Dev->>Img: Set USER, ENTRYPOINT, CMD
end
rect rgba(240,255,240,0.5)
note over Img,Ctr: Runtime
Ctr->>Img: Start container with ENTRYPOINT/CMD as configured
note over Img: No build-added `user_setup` adjustments to HOME or `/etc/passwd`
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove user_setup script Signed-off-by: liranmauda <liran.mauda@gmail.com>
a340258 to
517a771
Compare
dannyzaken
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Remove user_setup script
Fixes:
https://issues.redhat.com/browse/DFBUGS-2839
Summary by CodeRabbit