pkg/system/autoscaler.go (3)

414-438: Verify service discovery: using ServiceAccountName as Service name looks incorrect.

getPrometheusURL constructs a Service with Name = Prometheus.Spec.ServiceAccountName. That field is a service account, not a Service. Please confirm a Service with that name actually exists in your target clusters; otherwise, resolve the Service by known labels/selectors or make the Service name configurable.

I can suggest a label-based lookup (and a fallback to a user-provided service name) if desired.

---

259-271: Tighten user-facing messages: multiple typos and wording issues.

These show up in logs/errors and degrade UX. Suggested fixes:

-	log.Errorf("❌  Keda deploymen not ready")
+	log.Errorf("❌  Keda deployment not ready")

-			log.Errorf("Falied to delete HPAV1 existing %q autoscaler", autoscalersName)
-			return fmt.Errorf("falied to delete HPAV1 existing %q autoscaler", autoscalersName)
+			log.Errorf("Failed to delete HPAV1 existing %q autoscaler", autoscalersName)
+			return fmt.Errorf("failed to delete HPAV1 existing %q autoscaler", autoscalersName)

-		log.Errorf("Falied to delete Keda existing %q autoscaler", autoscalersv2.Items[0].Name)
-		return fmt.Errorf("Falied to delete Keda existing %q autoscaler", autoscalersv2.Items[0].Name)
+		log.Errorf("Failed to delete Keda existing %q autoscaler", autoscalersv2.Items[0].Name)
+		return fmt.Errorf("failed to delete Keda existing %q autoscaler", autoscalersv2.Items[0].Name)

-			log.Errorf("falied to delete HPAV2 Resources : %s", err)
+			log.Errorf("failed to delete HPAV2 resources: %s", err)
-			log.Errorf("Falied to delete HPAV2 existing %q autoscaler", item.Name)
-			return fmt.Errorf("falied to delete HPAV2 existing %q autoscaler", item.Name)
+			log.Errorf("Failed to delete HPAV2 existing %q autoscaler", item.Name)
+			return fmt.Errorf("failed to delete HPAV2 existing %q autoscaler", item.Name)

-		log.Println("❌ Failed to find the promethues port")
-		return "", fmt.Errorf("Failed to find the promethues port")
+		log.Println("❌ Failed to find the prometheus port")
+		return "", fmt.Errorf("failed to find the prometheus port")

-		return fmt.Errorf("Error while crateiing APIService prometheus-adapter")
+		return fmt.Errorf("error while creating APIService prometheus-adapter")

-		return fmt.Errorf("Error while crateiing ClusterRole prometheus-adapter-resource-reader")
+		return fmt.Errorf("error while creating ClusterRole prometheus-adapter-resource-reader")
-		return fmt.Errorf("Error while crateiing ClusterRoleBinding prometheus-adapter-system-auth-delegator")
+		return fmt.Errorf("error while creating ClusterRoleBinding prometheus-adapter-system-auth-delegator")
-		return fmt.Errorf("Error while crateiing RoleBinding prometheus-adapter-auth-reader")
+		return fmt.Errorf("error while creating RoleBinding prometheus-adapter-auth-reader")
-		return fmt.Errorf("Error while crateiing ClusterRoleBinding prometheus-adapter-resource-reader")
+		return fmt.Errorf("error while creating ClusterRoleBinding prometheus-adapter-resource-reader")

Optional: rename promethesNamespace → prometheusNamespace throughout for consistency.

Also applies to: 111-113, 133-135, 165-167, 433-435, 506-507, 542-563

---

357-365: Optional: narrow Prometheus selection.

KubeList without a selector may pick an arbitrary Prometheus if multiple exist in the namespace. Consider filtering by labels or name to avoid ambiguity.

pkg/options/options.go (1)

182-184: Image/version mismatch: deploying 1.25.0 image with 1.27.0 manifests.

This can drift behavior and APIs. If keeping 1.25.0 temporarily is intentional, add a TODO and track follow-up to switch to 1.27.0 when the noobaa-flavored image is published.

-var CnpgImage = "quay.io/noobaa/cloudnative-pg-noobaa:v1.25.0"
+// TODO(DFBUGS-3830): bump to v1.27.0 once the noobaa-flavored image is built and published
+var CnpgImage = "quay.io/noobaa/cloudnative-pg-noobaa:v1.25.0"

pkg/cnpg/cnpg.go (2)

548-551: Hard-coding CRD count is brittle; prefer validating required CRD names.

Upstream may add/remove CRDs across minors/patches. Instead of exact count, verify presence of the specific CRDs you require and warn on extras.

I can provide a helper that checks a set of required CRD names and reports which are missing/unexpected.

---

427-438: Nit: variable typo (mofifiedManifestBytes).

Rename to modifiedManifestBytes for readability.

-	mofifiedManifestBytes := bytes.ReplaceAll(manifestBytes,
+	modifiedManifestBytes := bytes.ReplaceAll(manifestBytes,
 		[]byte(originalGroup),
 		[]byte(noobaaGroupDomain))
...
-	mofifiedManifestBytes = bytes.ReplaceAll(mofifiedManifestBytes,
+	modifiedManifestBytes = bytes.ReplaceAll(modifiedManifestBytes,
 		[]byte(originalPath),
 		[]byte(newPath))
...
-	return mofifiedManifestBytes
+	return modifiedManifestBytes

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

go.mod (1)

3-3: Fix go directive: patch versions aren’t allowed.

Use major.minor only and add a separate toolchain pin.

-go 1.24.1
+go 1.24
+toolchain go1.24.1

go.mod (1)

90-90: Prefer a tagged release over a pseudo-version for gorilla/websocket.

Use a stable tag (e.g., v1.5.4) for reproducibility unless you specifically need that commit.

-	github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect
+	github.com/gorilla/websocket v1.5.4 // indirect

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Neon-White
PR: noobaa/noobaa-operator#1637
File: Makefile:193-203
Timestamp: 2025-06-25T15:42:04.436Z
Learning: golangci-lint v2.x versions output the version with a leading "v" prefix (e.g., "golangci-lint has version v2.1.6..."), while v1.x versions output without the "v" prefix (e.g., "golangci-lint has version 1.64.8..."). Version detection logic should account for the specific version format being targeted.

go.mod (2)

3-3: Fix go directive: patch versions aren’t allowed.

Use major.minor and add a toolchain line.

-go 1.24.1
+go 1.24
+toolchain go1.24.1

---

49-59: Verify k8s/controller-runtime minor alignment and older module pins.

You’ve got k8s v0.33.x with controller-runtime v0.21.0 alongside older kube-aggregator v0.27.1 and kubectl v0.25.4. Please confirm compatibility or bump/pin intentionally.

Run:

#!/bin/bash
# Show controller-runtime and k8s minors
go list -m -json all | jq -r '
  select(.Path=="sigs.k8s.io/controller-runtime" or (.Path|startswith("k8s.io/")))
  | "\(.Path) \(.Version)"
' | sort

Also applies to: 64-64

pkg/cnpg/cnpg.go (2)

548-551: Avoid fragile CRD hard-count; tolerate additions while guarding against missing core CRDs.

Pinning to an exact count breaks on upstream adding CRDs. Require a minimum and allow extras.

-    expectedNumberOfCrds := 10
-    if len(cnpgRes.CRDs) != expectedNumberOfCrds {
-        return nil, fmt.Errorf("expected %d CustomResourceDefinitions, got %d", expectedNumberOfCrds, len(cnpgRes.CRDs))
-    }
+    const minExpectedCRDs = 10
+    if len(cnpgRes.CRDs) < minExpectedCRDs {
+        return nil, fmt.Errorf("expected at least %d CustomResourceDefinitions for CNPG %s, got %d",
+            minExpectedCRDs, options.CnpgVersion, len(cnpgRes.CRDs))
+    }

---

427-439: Typo: “mofifiedManifestBytes” → “modifiedManifestBytes”.

Minor readability fix.

-    mofifiedManifestBytes := bytes.ReplaceAll(manifestBytes,
+    modifiedManifestBytes := bytes.ReplaceAll(manifestBytes,
         []byte(originalGroup),
         []byte(noobaaGroupDomain))
 ...
-    mofifiedManifestBytes = bytes.ReplaceAll(mofifiedManifestBytes,
+    modifiedManifestBytes = bytes.ReplaceAll(modifiedManifestBytes,
         []byte(originalPath),
         []byte(newPath))
 
-    return mofifiedManifestBytes
+    return modifiedManifestBytes

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Neon-White
PR: noobaa/noobaa-operator#1637
File: Makefile:193-203
Timestamp: 2025-06-25T15:42:04.436Z
Learning: golangci-lint v2.x versions output the version with a leading "v" prefix (e.g., "golangci-lint has version v2.1.6..."), while v1.x versions output without the "v" prefix (e.g., "golangci-lint has version 1.64.8..."). Version detection logic should account for the specific version format being targeted.

go.mod (2)

49-55: Verify ctrl-runtime/k8s minor compatibility

controller-runtime v0.21.0 with k8s v0.33.3 should match the official matrix; please double-check to avoid subtle API/serializer issues.

Also applies to: 64-64

---

3-3: Fix go directive: patch versions aren’t allowed

Use major.minor and add a separate toolchain pin.

-go 1.24.1
+go 1.24
+toolchain go1.24.1

pkg/noobaaaccount/noobaaaccount.go (1)

668-671: Reconcile loop now ignores res.Requeue; verify no callers rely on it

If any reconciler returns Requeue=true without RequeueAfter, this loop will prematurely stop. Either confirm that never happens or reintroduce the Requeue check.

Also fix the retry log to show actual durations:

-    if res.RequeueAfter != 0 {
-        log.Printf("\nRetrying in %d seconds\n", interval)
-        return false, nil
-    }
+    if res.RequeueAfter != 0 {
+        log.Printf("\nController requested requeue after %s; CLI poll interval is %s\n",
+            res.RequeueAfter.Round(time.Second), interval*time.Second)
+        return false, nil
+    }

pkg/backingstore/backingstore.go (1)

1054-1057: Behavior change: only RequeueAfter triggers retry

Dropping res.Requeue can exit early if a reconciler sets only Requeue=true. Please verify upstream reconcilers or keep the fallback.

Improve the retry log to reflect real timing:

-    if res.RequeueAfter != 0 {
-        log.Printf("\nRetrying in %d seconds\n", interval)
-        return false, nil
-    }
+    if res.RequeueAfter != 0 {
+        log.Printf("\nController requested requeue after %s; CLI poll interval is %s\n",
+            res.RequeueAfter.Round(time.Second), interval*time.Second)
+        return false, nil
+    }

pkg/bucketclass/bucketclass.go (1)

578-581: Retry condition narrowed; confirm no plain Requeue usages remain

Exiting when RequeueAfter==0 ignores Requeue=true. Validate callers or restore the Requeue check.

Tweak the log for accurate duration output:

-    if res.RequeueAfter != 0 {
-        log.Printf("\nRetrying in %d seconds\n", interval)
-        return false, nil
-    }
+    if res.RequeueAfter != 0 {
+        log.Printf("\nController requested requeue after %s; CLI poll interval is %s\n",
+            res.RequeueAfter.Round(time.Second), interval*time.Second)
+        return false, nil
+    }

go.mod (1)

21-21: CNPG 1.27.0 bump: align images/CRDs and docs

Since module is now v1.27.0, ensure:

• default CNPG image tag is updated (still 1.25.0 per PR notes),
• noobaa-flavor 1.27.0 image is built/pushed,
• CRD count/validation and docs reflect 1.27.0.

Happy to draft a follow-up PR/issue checklist for the image build and doc updates.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: Neon-White
PR: noobaa/noobaa-operator#1637
File: Makefile:193-203
Timestamp: 2025-06-25T15:42:04.436Z
Learning: golangci-lint v2.x versions output the version with a leading "v" prefix (e.g., "golangci-lint has version v2.1.6..."), while v1.x versions output without the "v" prefix (e.g., "golangci-lint has version 1.64.8..."). Version detection logic should account for the specific version format being targeted.