pkg/obc/provisioner.go (3)

470-475: Normalize user-provided path; treat "/" and trailing slashes as empty.

Edge case: users might pass "/" or "foo/". Normalizing avoids creating a root path or unexpected directories.

Apply this diff and add the import:

@@
-        path := r.OBC.Spec.AdditionalConfig["path"]
-        if path == "" {
-            path = r.BucketName
-        }
+        // Normalize: trim leading/trailing slashes so "/" becomes empty and defaults to bucket name.
+        path := strings.Trim(r.OBC.Spec.AdditionalConfig["path"], "/")
+        if path == "" {
+            path = r.BucketName
+        }
         createBucketParams.Namespace = bucketclass.CreateNamespaceBucketInfoStructure(*r.BucketClass.Spec.NamespacePolicy, path)

Add import:

 import (
+    "strings"
 )

---

470-475: Add a lightweight test to lock the default-path behavior.

Recommend a unit test that provisions with NamespacePolicy and no path in AdditionalConfig, asserting the computed path passed into the namespace bucket info equals the bucket name. Mocking the NB client or factoring path selection into a small helper would make this trivial.

I can refactor path selection into a small helper and add a focused test—want me to push that?

---

470-475: Confirm Path Is Applied for All Single/Multi Namespace Policies

I dug into CreateNamespaceBucketInfoStructure and found that for both NSBucketClassTypeSingle and NSBucketClassTypeMulti, the passed-in path is always set on the WriteResource (even when the underlying namespace store is S3/Azure/GCP). Only Cache-type policies ignore it. In other words, your change to default path = r.BucketName will now prefix every Single/Multi namespace bucket – regardless of backing‐store type – with the bucket name.

Please review whether that global prefixing is intended for cloud‐backed buckets. If you meant to only default a filesystem mountpoint for NSFS, consider guarding the defaulting logic so it only applies when the namespace store is actually NSFS. For example:

• In pkg/obc/provisioner.go, wrap the defaulting in an NSFS check instead of always falling back to r.BucketName.
• Or add a conditional around CreateNamespaceBucketInfoStructure so that path remains empty for non-NSFS bucketclasses.

Let me know if you’d like suggestions on implementing the gating.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.