Added a fix for DCO failure#1675
Conversation
Signed-off-by: Aayush Chouhan <achouhan@redhat.com>
WalkthroughThe GitHub Actions workflow .github/workflows/update-noobaa-core-tag.yml was updated to add the -s flag to the git commit command, ensuring commits are signed off. No other steps or control flow were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/update-noobaa-core-tag.yml (1)
49-56: Optionally verify the DCO sign-off before pushing.A lightweight guard can prevent pushing if, for any reason, the sign-off is missing.
Apply this diff within the step to add a verification guard:
git checkout -B update-core-tag-${{ steps.generate_tag.outputs.container_image_tag }} git add pkg/options/options.go - git commit -s -m "chore: update noobaa-core image tag to ${{ steps.generate_tag.outputs.container_image_tag }}" + git commit -s -m "chore: update noobaa-core image tag to ${{ steps.generate_tag.outputs.container_image_tag }}" + # Verify DCO sign-off is present + if ! git log -1 --pretty=%B | grep -qi '^Signed-off-by:'; then + echo "DCO sign-off not found; aborting push" + exit 1 + fi git push origin update-core-tag-${{ steps.generate_tag.outputs.container_image_tag }}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/update-noobaa-core-tag.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/update-noobaa-core-tag.yml (1)
55-55: Sign-off added to commit resolves DCO failure.Adding -s ensures a proper "Signed-off-by" trailer matching the configured bot identity, which should satisfy DCO checks.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
-sflag to the commit command to include a sign-off.Added github workflow to automatic update noobaa-core image tag #1642
Added monthly scheduling and automation of container image tag #1658
Testing Instructions:
Summary by CodeRabbit