CI | Upgrade tests | workflow fixes#1670
Merged
romayalon merged 1 commit intonoobaa:masterfrom Aug 7, 2025
Merged
Conversation
WalkthroughThe changes update the name of a GitHub Actions workflow from "Full Upgrade Test" to "Manual Upgrade Test" and modify the Makefile so that the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
jackyalbo
approved these changes
Aug 7, 2025
4b8ad57 to
58b046b
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/manual-upgrade-tests.yaml (1)
1-1: Consider aligning the job identifier with the new workflow nameThe workflow has been renamed to “Manual Upgrade Test”, but the single job inside is still called
nightly-upgrade-tests(Line 13). This mismatch is only cosmetic, yet keeping names consistent helps avoid confusion when debugging in the Actions UI or when referencing the job in reusable workflows.Makefile (1)
308-308: Redundant dependency –genis already pulled in viacli
test-upgrade: gen clilists bothgenandcli, while theclitarget itself depends ongen.
Make will rungen, thencli, and skip re-runninggen, so there is no functional bug—just an unnecessary extra prerequisite that lengthens the command line and can confuse future maintainers.Minimal, cleaner alternative:
-test-upgrade: gen cli +test-upgrade: cliFunctionality remains identical and the intent is clearer.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/manual-upgrade-tests.yaml(1 hunks)Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: run-operator-tests
- GitHub Check: cnpg-deployment-test
- GitHub Check: run-core-config-map-tests
- GitHub Check: run-cli-tests
- GitHub Check: run-azure-vault-test
- GitHub Check: run-admission-test
- GitHub Check: run-kms-key-rotate-test
- GitHub Check: run-kms-tls-token-test
- GitHub Check: run-kms-tls-sa-test
- GitHub Check: run-hac-test
- GitHub Check: run-kms-dev-test
- GitHub Check: run-kms-kmip-test
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
58b046b to
de56ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Summary by CodeRabbit
Summary by CodeRabbit
test-upgradeprocess now depends on updated targets, ensuring necessary components are generated before testing.