Check Noobaa core socket for ReadinessProbe. by naveenpaul1 · Pull Request #1656 · noobaa/noobaa-operator

naveenpaul1 · 2025-07-14T12:25:56Z

Explain the changes

Before Noobaa core ReadinessProbe was based on the /version endpoint, but the version endpoint needs to be authenticated before accessing. It's not possible for ReadinessProbe
httpGet inside is removed, and ReadinessProbe will return success when the noobaa core socket is up.

Issues: Fixed #xxx / Gap #xxx

Noobaa deployment was failing because of Noobaa core ReadinessProbe

Testing Instructions:

Deploy Noobaa inside Kubernetes and check deployment completed without the issue

Doc added/updated
Tests added

Summary by CodeRabbit

Refactor
- Updated the health check mechanism for the "core" service from an HTTP-based readiness probe to a TCP socket probe on port 8080. The timing settings remain unchanged. This may affect how readiness is determined for the service but does not impact user-facing features.

Signed-off-by: Naveen Paul <napaul@redhat.com>

coderabbitai · 2025-07-14T12:26:02Z

Walkthrough

The readiness probe configuration for the "core" container was changed from an HTTP GET request to a TCP socket check on port 8080 across deployment YAML, Go bundle, and system phase files. Associated constants and YAML content were updated to reflect this change, while timing parameters remained the same.

Changes

File(s)	Change Summary
deploy/internal/statefulset-core.yaml	Changed readiness probe for "core" container from HTTP GET on /version to TCP socket on port 8080.
pkg/bundle/deploy.go	Updated SHA256 checksum constant and readiness probe YAML from HTTP GET to TCP socket check.
pkg/system/phase2_creating.go	Modified readiness probe for "core" container from HTTP GET to TCP socket on port 8080.

Sequence Diagram(s)

sequenceDiagram
    participant Kubelet
    participant CoreContainer

    Kubelet->>CoreContainer: TCP connection check on port 8080 (readinessProbe)
    alt Connection successful
        CoreContainer-->>Kubelet: Ready
    else Connection failed
        CoreContainer-->>Kubelet: Not Ready
    end

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0baa57e and dc734fd.

📒 Files selected for processing (3)

deploy/internal/statefulset-core.yaml (1 hunks)
pkg/bundle/deploy.go (2 hunks)
pkg/system/phase2_creating.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

GitHub Check: run-hac-test
GitHub Check: run-kms-kmip-test
GitHub Check: run-operator-tests
GitHub Check: run-core-config-map-tests
GitHub Check: golangci-lint
GitHub Check: run-kms-dev-test
GitHub Check: run-kms-key-rotate-test
GitHub Check: run-cli-tests
GitHub Check: run-kms-tls-sa-test
GitHub Check: cnpg-deployment-test
GitHub Check: run-admission-test
GitHub Check: run-kms-tls-token-test
GitHub Check: run-azure-vault-test

🔇 Additional comments (4)

deploy/internal/statefulset-core.yaml (1)

55-58: LGTM: Readiness probe change addresses authentication issue.

The change from httpGet to tcpSocket is appropriate for readiness probes. TCP socket checks are simpler and don't require authentication, which resolves the deployment failures mentioned in the PR objectives. The port 8080 and timing parameters are correctly maintained.

pkg/system/phase2_creating.go (1)

567-569: LGTM: Go code change is consistent with YAML configuration.

The readiness probe configuration correctly uses TCPSocketAction with intstr.FromInt(8080), which is consistent with the YAML file change. The implementation properly follows the Kubernetes client-go patterns for probe configuration.

pkg/bundle/deploy.go (2)

5057-5057: SHA256 constant updated – looks good.

The checksum change aligns with the modified YAML blob. 👍

5112-5116: No residual /version HTTP readiness probes found

Ran a multiline ripgrep search for any readinessProbe blocks using httpGet.path: /version and there were zero matches. The switch to the TCP socket probe is complete—no further removals needed.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Check Noobaa core socket for ReadinessProbe.

dc734fd

Signed-off-by: Naveen Paul <napaul@redhat.com>

naveenpaul1 requested a review from dannyzaken July 14, 2025 12:26

pull-request-size bot added the size/S label Jul 14, 2025

naveenpaul1 requested a review from tangledbytes July 15, 2025 06:42

dannyzaken approved these changes Jul 15, 2025

View reviewed changes

naveenpaul1 merged commit 5488c39 into noobaa:master Jul 15, 2025
16 checks passed

coderabbitai bot mentioned this pull request Jul 15, 2025

CA Paths Fixes #1587

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check Noobaa core socket for ReadinessProbe.#1656

Check Noobaa core socket for ReadinessProbe.#1656
naveenpaul1 merged 1 commit intonoobaa:masterfrom
naveenpaul1:socket-readiness-prob

naveenpaul1 commented Jul 14, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 14, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

naveenpaul1 commented Jul 14, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explain the changes

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

naveenpaul1 commented Jul 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 14, 2025 •

edited

Loading