Block NSS creation when SignatureVersion v4 and endpoint non-secure#1580
Merged
naveenpaul1 merged 1 commit intonoobaa:masterfrom Apr 21, 2025
Merged
Block NSS creation when SignatureVersion v4 and endpoint non-secure#1580naveenpaul1 merged 1 commit intonoobaa:masterfrom
naveenpaul1 merged 1 commit intonoobaa:masterfrom
Conversation
fe44d40 to
180b606
Compare
liranmauda
reviewed
Apr 7, 2025
180b606 to
bfc2d55
Compare
jackyalbo
reviewed
Apr 16, 2025
Contributor
|
@naveenpaul1 - I think the same code change can also be added in the backingstore CLI (it has similar options like namespacestore CLI in some of the cases), WDYT? |
bfc2d55 to
b1c62e8
Compare
b1c62e8 to
744cfba
Compare
744cfba to
c9fccf8
Compare
jackyalbo
reviewed
Apr 21, 2025
Signed-off-by: naveenpaul1 <napaul@redhat.com>
c9fccf8 to
eb4362b
Compare
jackyalbo
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
No change for Backingstore since uploadPart upload(Non-file stream) is not supported by backingstore.
Issues: Fixed #xxx / Gap #xxx
NSS is in rejected state because the endpoint provided is non-secure and CLI is adding signature version to the endpoint request when try to access data this is creating issue in aws-sdk
related Github issue: aws/aws-sdk-js#965
Testing Instructions: