Merged
Conversation
60c8f44 to
6e36f9f
Compare
6e36f9f to
cc24f1b
Compare
- added support to node affinity and tolerations - added postgresql config values to cluster spec Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
cc24f1b to
74d453f
Compare
liranmauda
reviewed
Mar 30, 2025
liranmauda
approved these changes
Mar 30, 2025
Contributor
liranmauda
left a comment
There was a problem hiding this comment.
LGTM, one comment on the printing.
jackyalbo
reviewed
Mar 30, 2025
| log.Printf(" - You may Ctrl-C at any time to stop the loop and watch it manually.") | ||
| } | ||
|
|
||
| // WaitForOperatorDeploymentReady waits for a deployment to be have the desired number of replicas ready |
Contributor
There was a problem hiding this comment.
Suggested change
| // WaitForOperatorDeploymentReady waits for a deployment to be have the desired number of replicas ready | |
| // WaitForOperatorDeploymentReady waits for a deployment to have the desired number of replicas ready |
| log.Printf("") | ||
| } | ||
|
|
||
| // wait for the operators to be ready before creating the system |
Contributor
There was a problem hiding this comment.
Do we have to have this part now? Usually, I break(Ctrl-C) the install when waiting for the system to be Ready, but now breaking the install on wait won't create the system.
Also, should(can) we add no-wait option support here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
dbConffield todbSpecto allow overriding default parametersChanges to install flow
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: