Skip to content

gen_odf - quote with single quote#1552

Merged
alphaprinz merged 1 commit intonoobaa:masterfrom
alphaprinz:gen_odf_quotes
Mar 6, 2025
Merged

gen_odf - quote with single quote#1552
alphaprinz merged 1 commit intonoobaa:masterfrom
alphaprinz:gen_odf_quotes

Conversation

@alphaprinz
Copy link
Contributor

Explain the changes

  1. Use different quotes for entire cmd and single commands inside it to support env vars with space.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

REPLACES="has space" OBC_CRD=none MANIFESTS=MA CSV_NAME=CS CORE_IMAGE=CO PSQL_12_IMAGE=PS DB_IMAGE=DB OPERATOR_IMAGE=OP COSI_SIDECAR_IMAGE=CO ./build/gen-odf-package.sh
--obc-crd=none

  • Doc added/updated
  • Tests added

Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
@alphaprinz alphaprinz merged commit 15624d1 into noobaa:master Mar 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants