Setting noobaa account state "rejected"#1509
Merged
vh05 merged 1 commit intonoobaa:masterfrom Jan 16, 2025
Merged
Conversation
Contributor
|
@vh05 Why do we only return util.NewPersistentError on the update? noobaa-operator/pkg/noobaaaccount/reconciler.go Lines 354 to 357 in 15f7a29 |
Missing default_resource parameter which is mandatory parameter for account creation, should mark the nooobaa account status as rejected Fixes: #https://issues.redhat.com/browse/DFBUGS-1297 Signed-off-by: Vinayak Hariharmath <vinayak.hariharmath@gmail.com>
liranmauda
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing default_resource parameter which is mandatory parameter for account creation, should mark the nooobaa account status as rejected
Fixes: #https://issues.redhat.com/browse/DFBUGS-1297