Noobaa/Backingstore : Need facility to change labels#1489
Merged
aspandey merged 1 commit intonoobaa:masterfrom Jan 9, 2025
Merged
Noobaa/Backingstore : Need facility to change labels#1489aspandey merged 1 commit intonoobaa:masterfrom
aspandey merged 1 commit intonoobaa:masterfrom
Conversation
b7f49cc to
7225cfa
Compare
1659838 to
8971095
Compare
Comment on lines
+1316
to
+1319
| bs_label, ok := r.BackingStore.Labels["backingstore"] | ||
| if !ok || bs_label == "" { | ||
| bs_label = "noobaa" | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| bs_label, ok := r.BackingStore.Labels["backingstore"] | |
| if !ok || bs_label == "" { | |
| bs_label = "noobaa" | |
| } | |
| bs_label := r.BackingStore.Labels["backingstore"] | |
| if bs_label == "" { | |
| bs_label = "noobaa" | |
| } |
Just a small suggestion, I think it will return zero "" value if the label is not defined so we can update it.
8971095 to
4a29b59
Compare
6fde234 to
79e3fb0
Compare
We need to allow to modify the matchLabel of topologySpreadConstraints for noobaa's backingstore pods. https://issues.redhat.com/browse/DFBUGS-277 Signed-off-by: Ashish Pandey <aspandey@redhat.com>
79e3fb0 to
6d562a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to allow to modify the matchLabel of
topologySpreadConstraints for noobaa's backingstore pods.
https://issues.redhat.com/browse/DFBUGS-277
Testing -
1 - Create a backing store.
2 - Check the label for backingstore and also the pod
kubectl get backingstore my-backingstore -o yaml
kubectl describe pod my-backingstore-noobaa-pod-c2348d65
3 -
Change the label of a backingstore object like this -
kubectl label backingstore my-backingstore backingstore=noobaa-new --overwrite
This will trigger the reconciliation and the pod will be reinitialize and now have a "backingstore=noobaa-new" as label