Skip to content

Adapting operator to new bucket list API change#1473

Merged
jackyalbo merged 1 commit intonoobaa:masterfrom
jackyalbo:jacky-fixes
Nov 12, 2024
Merged

Adapting operator to new bucket list API change#1473
jackyalbo merged 1 commit intonoobaa:masterfrom
jackyalbo:jacky-fixes

Conversation

@jackyalbo
Copy link
Contributor

@jackyalbo jackyalbo commented Nov 11, 2024

Explain the changes

  1. After changing the api for list buckets, we need to update operator to support it as well otherwise nb api will fail listing the buckets
  2. Adding the new params to the API
  3. updating the list bucket nb cli command to support the new params

Issues: Fixed #xxx / Gap #xxx

  1. Fixed https://issues.redhat.com/browse/DFBUGS-822

Testing Instructions:

  1. run the scenario in the bug: noobaa-cli bucket list
  2. make sure you see the buckets and no schema errors appear
  • Doc added/updated
  • Tests added

@jackyalbo
Adapting operator to new bucket list API change
066a328 
Adapting operator to new bucket list API change

Signed-off-by: jackyalbo <jacky.albo@gmail.com>
@jackyalbo jackyalbo requested a review from dannyzaken November 11, 2024 14:52
liranmauda
liranmauda approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
@jackyalbo I wonder why the CI tests did not find it. can we have a look, and open a gap if needed?

@jackyalbo jackyalbo merged commit b62bb7e into noobaa:master Nov 12, 2024
@jackyalbo
Copy link
Contributor Author

jackyalbo commented Nov 12, 2024

@liranmauda I'm not sure if it would have caught the issue, but I don't think that we are using latest noobaa-core in our CI tests for operator. I guess we are using options.ContainerImageTag which is at least 6 months ago (master-20240520).
in anyway we are always running bucket list with silence option which I'm not sure if avoids failing the test: test_noobaa silence bucket list
We don't have a dedicated test for buckets in our cli, so a lot is missing.

@liranmauda
Copy link
Contributor

liranmauda commented Nov 12, 2024

@liranmauda I'm not sure if it would have caught the issue, but I don't think that we are using latest noobaa-core in our CI tests for operator. I guess we are using options.ContainerImageTag which is at least 6 months ago (master-20240520). in anyway we are always running bucket list with silence option which I'm not sure if avoids failing the test: test_noobaa silence bucket list We don't have a dedicated test for buckets in our cli, so a lot is missing.

Thanks, we should close this gap to avoid those kinds of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@liranmauda liranmauda liranmauda approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackyalbo @liranmauda @dannyzaken