Skip to content

Updating controller-runtime to v0.19.0#1461

Merged
liranmauda merged 1 commit intonoobaa:masterfrom
liranmauda:liran-bump-deepcopy-gen
Oct 27, 2024
Merged

Updating controller-runtime to v0.19.0#1461
liranmauda merged 1 commit intonoobaa:masterfrom
liranmauda:liran-bump-deepcopy-gen

Conversation

@liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Oct 13, 2024

Explain the changes

Updating controller-runtime to v0.19.0

controller-runtime added a name verification.
All noobaa controllers are named the same (noobaa-controller) which leads to Controller names must be unique to avoid multiple controllers reporting to the same metric

there are 2 options:

  1. Set a different name
  2. set:
controller.Options{
		SkipNameValidation: &[]bool{true}[0],
	}

For now, I plan to skip the validation, If we see a value to change it later to use a different name per controller (we could open a gap).

Signed-off-by: liranmauda liran.mauda@gmail.com

@liranmauda liranmauda force-pushed the liran-bump-deepcopy-gen branch 3 times, most recently from 378eb2f to 2e64d32 Compare October 13, 2024 12:21
Updating controller-runtime to v0.19.0
Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda force-pushed the liran-bump-deepcopy-gen branch from 2e64d32 to dd189c6 Compare October 14, 2024 13:45
@liranmauda liranmauda merged commit c611e73 into noobaa:master Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants