Updating controller-runtime to v0.19.0#1461
Merged
liranmauda merged 1 commit intonoobaa:masterfrom Oct 27, 2024
Merged
Conversation
378eb2f to
2e64d32
Compare
Updating controller-runtime to v0.19.0 Signed-off-by: liranmauda <liran.mauda@gmail.com>
2e64d32 to
dd189c6
Compare
dannyzaken
approved these changes
Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes
Updating controller-runtime to v0.19.0
controller-runtime added a name verification.
All noobaa controllers are named the same (noobaa-controller) which leads to Controller names must be unique to avoid multiple controllers reporting to the same metric
there are 2 options:
For now, I plan to skip the validation, If we see a value to change it later to use a different name per controller (we could open a gap).
Signed-off-by: liranmauda liran.mauda@gmail.com